[PRE REVIEW]: cdsaxs: A model fitting package for CD-SAXS data analysis

[editorialbot]

Submitting author: @mrhxszo (nischal dhungana)
Repository: https://github.com/CEA-MetroCarac/cdsaxs
Branch with paper.md (empty if default branch): paper
Version: v0.0.2
Editor: @srmnitc
Reviewers: @benjaminbolling, @marcocamma
Managing EiC: Kevin M. Moerman

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ed3d2c3d186d1407b25b6096e3c0ee57"><img src="https://joss.theoj.org/papers/ed3d2c3d186d1407b25b6096e3c0ee57/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ed3d2c3d186d1407b25b6096e3c0ee57/status.svg)](https://joss.theoj.org/papers/ed3d2c3d186d1407b25b6096e3c0ee57)

Author instructions

Thanks for submitting your paper to JOSS @mrhxszo. Currently, there isn't a JOSS editor assigned to your paper.

@mrhxszo if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1107/S1600576715013369 is OK
- 10.1117/1.JMM.15.1.014001 is OK
- 10.1117/1.JMM.15.3.034001 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (1118.9 files/s, 179505.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          13            506            557           1267
Jupyter Notebook                 5              0           1465            405
reStructuredText                 7            221            129            214
Markdown                         2             77              0            138
YAML                             2              7              4            119
TOML                             1             11              0             86
TeX                              1              3              0             30
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            33            837           2163           2294
-------------------------------------------------------------------------------

Commit count by author:

    82	Nischal Dhungana
    29	Matthew Bryan
    16	Nischal
    14	Nischal DHUNGANA ND276333
     5	DHUNGANA Nischal
     4	gfreychet
     1	patquem
     1	timothee_choisnet

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 926

✅ The paper includes a Statement of need section

[editorialbot]

License info:

✅ License found: MIT License (Valid open source OSI approved license)

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[editorialbot]

Five most similar historical JOSS papers:

Lightshow: a Python package for generating computational x-ray absorption spectroscopy input files
Submitting author: @matthewcarbone
Handling editor: @ppxasjsm (Active)
Reviewers: @maurov, @larsenkg
Similarity score: 0.7355

Reel1.0 - A visualization tool for evaluating powder diffraction refinements
Submitting author: @fgjorup
Handling editor: @rkurchin (Active)
Reviewers: @cmbiwer, @mikapfl
Similarity score: 0.7261

Surfaxe: Systematic surface calculations
Submitting author: @brlec
Handling editor: @danielskatz (Active)
Reviewers: @pzarabadip, @eihernan
Similarity score: 0.7231

FitBenchmarking: an open source Python package comparing data fitting software
Submitting author: @tyronerees
Handling editor: @dhhagan (Retired)
Reviewers: @johnsamuelwrites, @djmitche
Similarity score: 0.7226

Simmate: a framework for materials science
Submitting author: @jacksund
Handling editor: @rkurchin (Active)
Reviewers: @bocklund, @utf
Similarity score: 0.7141

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

[Kevin-Mattheus-Moerman]

@editorialbot check references

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1107/S1600576715013369 is OK
- 10.1117/1.JMM.15.1.014001 is OK
- 10.1117/1.JMM.15.3.034001 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

[Kevin-Mattheus-Moerman]

@mrhxszo Dear author, thanks for this submission. I am the AEiC on this track and here to help process the initial steps. Before we proceed, please can you have a look at the following points:

• Your project appears to lack contributing guidelines at the moment. Please work to add these and to mention/link to them in your README. You could for instance create a CONTRIBUTING.md file (see here for some examples: https://contributing.md/example/).

[Kevin-Mattheus-Moerman]

@editorialbot invite @srmnitc as editor

[editorialbot]

Invitation to edit this submission sent!

[mrhxszo]

@Kevin-Mattheus-Moerman Thank you for your help. I've added CONTRIBUTING.md and linked it on my README.md. Please let me know if you see further room for improvements.

[Kevin-Mattheus-Moerman]

@srmnitc 👋

[srmnitc]

@Kevin-Mattheus-Moerman sorry for the delay, I was travelling last week and unfortunately did not follow up with all the notifications. Looks interesting, I will take this up.

[srmnitc]

@editorialbot assign me as editor

[editorialbot]

Assigned! @srmnitc is now the editor

[srmnitc]

@mrhxszo I will be the handling editor for this submission. The next step would be to find some reviewers for the submission. Do you have any suggestions for potentials reviewers?

Meanwhile, feel free to ask me any questions here.

[srmnitc]

@ZhenchenHong @benjaminbolling @larsenkg @trygvrad, would any of you have time and be willing to review this submission for JOSS? As you might know, we carry out our checklist-driven reviews here in GitHub issues and follow these guidelines. Thanks for your time!

[benjaminbolling]

Hi there! I see not much has happened, sorry for the late reply. This is an interesting application. You can add me as a reviewer.

[srmnitc]

Thanks a lot @benjaminbolling. I was not available unfortunately, so you are not late at all :)

[srmnitc]

@editorialbot add @benjaminbolling as reviewer

[editorialbot]

@benjaminbolling added to the reviewers list!

[srmnitc]

@marcocamma @bmansel would any of you have time and be willing to review this submission for JOSS? As you might know, we carry out our checklist-driven reviews here in GitHub issues and follow these guidelines. Thanks for your time!

[srmnitc]

@jwuttke @stuartcampbell would any of you have time and be willing to review this submission for JOSS? As you might know, we carry out our checklist-driven reviews here in GitHub issues and follow these guidelines. Thanks for your time!

[marcocamma]

Sorry I was busy for a few weeks. Is help still needed ?

[srmnitc]

Sorry I was busy for a few weeks. Is help still needed ?

That would be very helpful, thank you! Shall I add you as a reviewer?

[marcocamma]

@srmnitc , yes please

[srmnitc]

@editorialbot add @marcocamma as reviewer

[editorialbot]

@marcocamma added to the reviewers list!

[srmnitc]

@editorialbot start review

[editorialbot]

OK, I've started the review over in #7559.