Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Virtual Engineering: Python framework for engineering process design #7498

Open
editorialbot opened this issue Nov 18, 2024 · 18 comments
Labels
pre-review Track: 3 (PE) Physics and Engineering waitlisted Submissions in the JOSS backlog due to reduced service mode.

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @olgadoronina (Olga Doronina)
Repository: https://github.com/NREL/VirtualEngineering
Branch with paper.md (empty if default branch):
Version: v0.1.0
Editor: Pending
Reviewers: Pending
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f888f1491f7b665ecf8f18ddd5c6b06d"><img src="https://joss.theoj.org/papers/f888f1491f7b665ecf8f18ddd5c6b06d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f888f1491f7b665ecf8f18ddd5c6b06d/status.svg)](https://joss.theoj.org/papers/f888f1491f7b665ecf8f18ddd5c6b06d)

Author instructions

Thanks for submitting your paper to JOSS @olgadoronina. Currently, there isn't a JOSS editor assigned to your paper.

@olgadoronina if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Nov 18, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "title" (NAME) ["@", #<BibTeX::Entry >, "%"]

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.28 s (587.0 files/s, 499022.8 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
Python                           53           1767           1493           5253
Fortran 90                       15            910            216           2203
m4                                4            282              0           1398
C/C++ Header                     10            138             75            729
C++                               5            229            158            699
liquid                           12             68              0            568
Markdown                          9            186              0            511
Jupyter Notebook                  3              0         120773            437
TeX                               4             66             47            311
reStructuredText                 13            108             56            134
Bourne Again Shell                9             25             84            114
YAML                              4             10              9             96
CSV                               5              0              0             83
Bourne Shell                     13              5              6             81
make                              3             13              8             40
DOS Batch                         1              8              1             26
INI                               1              2              0              4
--------------------------------------------------------------------------------
SUM:                            164           3817         122926          12687
--------------------------------------------------------------------------------

Commit count by author:

    96	Ethan Young
    39	Olga Doronina
    37	eyoung
    32	Jonathan Stickel
    22	Hariswaran Sitaraman
    13	Young
     6	Jim Lischeske
     4	Andrew Glaws
     4	hari
     4	hsitaram
     3	Lischeske
     1	Young, Ethan
     1	Yudong Li
     1	odoronin

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 2575

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Opyrability: A Python package for process operability analysis
Submitting author: @victoraalves
Handling editor: @kyleniemeyer (Active)
Reviewers: @gmxavier, @mustafaalsalmi1999
Similarity score: 0.6393

TESPy: Thermal Engineering Systems in Python
Submitting author: @fwitte
Handling editor: @kyleniemeyer (Active)
Reviewers: @arosen93, @corentin-dev
Similarity score: 0.6339

RHEIA: Robust design optimization of renewable Hydrogen and dErIved energy cArrier systems
Submitting author: @DCoppitters
Handling editor: @fraukewiese (Active)
Reviewers: @andr1976, @ClaraBuettner
Similarity score: 0.6320

PlantSimEngine: A Simulation Engine For The Soil-Plant-Atmosphere System
Submitting author: @VEZY
Handling editor: @crvernon (Active)
Reviewers: @ashiklom, @tpoisot, @tomyun
Similarity score: 0.6315

ParMOO: A Python library for parallel multiobjective simulation optimization
Submitting author: @thchang
Handling editor: @kellyrowland (Active)
Reviewers: @Viech, @JianqiaoMao
Similarity score: 0.6277

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kyleniemeyer
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "title" (NAME) ["@", #<BibTeX::Entry >, "%"]

@kyleniemeyer
Copy link

Hello @olgadoronina thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

While we are waiting, could you please:

  • Check the bibtex related error above? The paper compiled, but there seems to be an error. You can use the following commands (one at a time, as the first line of a new comment) to regenerate the PDF and check the references:
    @editorialbot generate pdf
    @editorialbot check references

  • Suggest some potential reviewers from our database? Please do not actually tag them with @

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@kyleniemeyer kyleniemeyer added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Nov 18, 2024
@olgadoronina
Copy link

@editorialbot generate pdf

@olgadoronina
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.cej.2015.01.020 is OK
- 10.1016/j.cej.2015.01.020 is OK
- 10.1016/j.cherd.2018.08.033 is OK
- 10.1007/10968987_3 is OK
- 10.1063/1.168744 is OK
- 10.3233/978-1-61499-649-1-87 is OK
- 10.1126/science.1246843 is OK
- 10.1039/D4VA00109E is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: ipywidgets: Interactive widgets for the Jupyter No...
- No DOI given, and none found for title: Keynote: Virtual Engineering Software Framework fo...
- No DOI given, and none found for title: Virtual Engineering of Low-Temperature Conversion

❌ MISSING DOIs

- 10.1186/s13068-019-1633-2 may be a valid DOI for title: A two-phase substrate model for enzymatic hydrolys...
- 10.2172/1013269 may be a valid DOI for title: Process design and economics for biochemical conve...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Opyrability: A Python package for process operability analysis
Submitting author: @victoraalves
Handling editor: @kyleniemeyer (Active)
Reviewers: @gmxavier, @mustafaalsalmi1999
Similarity score: 0.6394

TESPy: Thermal Engineering Systems in Python
Submitting author: @fwitte
Handling editor: @kyleniemeyer (Active)
Reviewers: @arosen93, @corentin-dev
Similarity score: 0.6341

RHEIA: Robust design optimization of renewable Hydrogen and dErIved energy cArrier systems
Submitting author: @DCoppitters
Handling editor: @fraukewiese (Active)
Reviewers: @andr1976, @ClaraBuettner
Similarity score: 0.6318

PlantSimEngine: A Simulation Engine For The Soil-Plant-Atmosphere System
Submitting author: @VEZY
Handling editor: @crvernon (Active)
Reviewers: @ashiklom, @tpoisot, @tomyun
Similarity score: 0.6316

ParMOO: A Python library for parallel multiobjective simulation optimization
Submitting author: @thchang
Handling editor: @kellyrowland (Active)
Reviewers: @Viech, @JianqiaoMao
Similarity score: 0.6280

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@olgadoronina
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.cej.2015.01.020 is OK
- 10.1016/j.cej.2015.01.020 is OK
- 10.1186/s13068-019-1633-2 is OK
- 10.1016/j.cherd.2018.08.033 is OK
- 10.1007/10968987_3 is OK
- 10.1063/1.168744 is OK
- 10.3233/978-1-61499-649-1-87 is OK
- 10.1126/science.1246843 is OK
- 10.2172/1013269 is OK
- 10.1039/D4VA00109E is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: ipywidgets: Interactive widgets for the Jupyter No...
- No DOI given, and none found for title: Keynote: Virtual Engineering Software Framework fo...
- No DOI given, and none found for title: Virtual Engineering of Low-Temperature Conversion

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@olgadoronina
Copy link

Hello @kyleniemeyer,

thanks for managing the paper. We corrected the Bibtex file, and here is the list of possible reviewers for the paper (not from the reviewer database):

  • Yidong Xia (INL), GitHub: yidongxiainl
  • Olawufemi Oyedji (ORNL). Github: ooyedeji
  • Mathew Liberatore (University of Toledo), email: [email protected]
  • Joe Saminiuk (Colorado School of Mines), email: [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Track: 3 (PE) Physics and Engineering waitlisted Submissions in the JOSS backlog due to reduced service mode.
Projects
None yet
Development

No branches or pull requests

3 participants