Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: jaxKAN: A unified JAX framework for Kolmogorov-Arnold Networks #7662

Closed
editorialbot opened this issue Jan 14, 2025 · 47 comments
Closed
Assignees
Labels
pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jan 14, 2025

Submitting author: @srigas (Spyros Rigas)
Repository: https://github.com/srigas/jaxkan
Branch with paper.md (empty if default branch): joss
Version: v0.2.0
Editor: @fabian-s
Reviewers: @kazewong, @ColCarroll
Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/6015037c6a6db77053a3f5abb2ee303f"><img src="https://joss.theoj.org/papers/6015037c6a6db77053a3f5abb2ee303f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/6015037c6a6db77053a3f5abb2ee303f/status.svg)](https://joss.theoj.org/papers/6015037c6a6db77053a3f5abb2ee303f)

Author instructions

Thanks for submitting your paper to JOSS @srigas. Currently, there isn't a JOSS editor assigned to your paper.

@srigas if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Jan 14, 2025
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.05 s (979.0 files/s, 276946.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Jupyter Notebook                18              0           8049           3075
Python                          19            652           1159           1026
TeX                              1             14              0            138
Markdown                         2             39              0            125
YAML                             4             13              9             83
reStructuredText                 7             89             93             79
TOML                             1             13              0             54
-------------------------------------------------------------------------------
SUM:                            52            820           9310           4580
-------------------------------------------------------------------------------

Commit count by author:

    41	srigas
    28	Spyros
    15	Spyros Rigas
     9	mixpap
     1	Dhanush Kovi

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1090

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

@srigas
Copy link

srigas commented Jan 14, 2025

Thank you for adding our work in pre-review, we look forward to collaborating with you in any way necessary to ensure a flawless review process! :)

The editorialbot failed to generate the paper at its first try, possibly due to a misidentation in the paper.md metadata, which we missed because compilation had no issues in our GitHub Actions automations. Nonetheless, it should work now.

As for possible reviewers, I'm afraid I do not have anyone in particular in mind, as I was only recently introduced to JOSS!

@srigas
Copy link

srigas commented Jan 14, 2025

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

PyKoopman: A Python Package for Data-Driven Approximation of the Koopman Operator
Submitting author: @pswpswpsw
Handling editor: @olexandr-konovalov (Active)
Reviewers: @ulf1, @fandreuz
Similarity score: 0.6637

PyKronecker: A Python Library for the Efficient Manipulation of Kronecker Products and Related Structures
Submitting author: @nickelnine37
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @JulianKarlBauer, @nicoguaro
Similarity score: 0.6602

SGMCMCJax: a lightweight JAX library for stochastic gradient Markov chain Monte Carlo algorithms
Submitting author: @jeremiecoullon
Handling editor: @dfm (Active)
Reviewers: @canyon289, @ColCarroll
Similarity score: 0.6585

flowMC: Normalizing flow enhanced sampling package for probabilistic inference in JAX
Submitting author: @kazewong
Handling editor: @rkurchin (Active)
Reviewers: @matt-graham, @Daniel-Dodd
Similarity score: 0.6566

Re-Envisioning Numerical Information Field Theory (NIFTy.re): A Library for Gaussian Processes and Variational Inference
Submitting author: @Edenhofer
Handling editor: @dfm (Active)
Reviewers: @Abinashbunty, @apizzuto
Similarity score: 0.6537

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@crvernon
Copy link

@editorialbot query scope

👋 @srigas - I am going to run this one by our larger editorial board for review to ensure that it meets our requirements. I'll be back in touch ASAP. Thanks

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Jan 17, 2025
@srigas
Copy link

srigas commented Jan 17, 2025

@crvernon By all means! In the process, let me know if there's anything I can help in clarifying.

@crvernon
Copy link

@srigas - we are going to move this one forward into review. I'll find you a topic editor ASAP. Thanks for your patience!

@crvernon
Copy link

@editorialbot invite @fabian-s as editor

👋 @fabian-s - can you take this one on as editor?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@crvernon crvernon removed the query-scope Submissions of uncertain scope for JOSS label Jan 28, 2025
@fabian-s
Copy link

@editorialbot add fabian-s as editor

@editorialbot
Copy link
Collaborator Author

Assigned! fabian-s is now the editor

@fabian-s
Copy link

👋 @kazewong @daniel-dodd @jeremiecoullon @KindXiaoming

would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@fabian-s
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.cma.2024.117290 is OK
- 10.1109/ACCESS.2024.3504962 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: KAN: Kolmogorov-Arnold Networks
- No DOI given, and none found for title: Flax: A neural network library and ecosystem for J...
- No DOI given, and none found for title: The DeepMind JAX Ecosystem
- No DOI given, and none found for title: Chebyshev Polynomial-Based Kolmogorov-Arnold Netwo...
- No DOI given, and none found for title: FourierKAN
- No DOI given, and none found for title: An Efficient Implementation of Kolmogorov-Arnold N...
- No DOI given, and none found for title: Kolmogorov-Arnold Networks (KANs)
- No DOI given, and none found for title: PyTorch: An Imperative Style, High-Performance Dee...
- No DOI given, and none found for title: NeuroMANCER: Neural Modules with Adaptive Nonlinea...
- No DOI given, and none found for title: Finite basis Kolmogorov-Arnold networks: domain de...
- No DOI given, and none found for title: Multifidelity Kolmogorov-Arnold Networks
- No DOI given, and none found for title: SPIKANs: Separable Physics-Informed Kolmogorov-Arn...

❌ MISSING DOIs

- 10.1016/j.cma.2022.115671 may be a valid DOI for title: A comprehensive study of non-adaptive and residual...

❌ INVALID DOIs

- None

@fabian-s
Copy link

@srigas
while I try to rustle up some reviewers for this, please take a look at the DOI the bot found (see above) and see if it's the right one for your reference.
if so, please add it to your bib-file.

@srigas
Copy link

srigas commented Jan 28, 2025

@srigas - we are going to move this one forward into review. I'll find you a topic editor ASAP. Thanks for your patience!

Sure, let me know if there's anything I can do to streamline the process on my end!

@srigas
Copy link

srigas commented Jan 28, 2025

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

SGMCMCJax: a lightweight JAX library for stochastic gradient Markov chain Monte Carlo algorithms
Submitting author: @jeremiecoullon
Handling editor: @dfm (Active)
Reviewers: @canyon289, @ColCarroll
Similarity score: 0.6688

PyKoopman: A Python Package for Data-Driven Approximation of the Koopman Operator
Submitting author: @pswpswpsw
Handling editor: @olexandr-konovalov (Active)
Reviewers: @ulf1, @fandreuz
Similarity score: 0.6687

PyKronecker: A Python Library for the Efficient Manipulation of Kronecker Products and Related Structures
Submitting author: @nickelnine37
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @JulianKarlBauer, @nicoguaro
Similarity score: 0.6678

Re-Envisioning Numerical Information Field Theory (NIFTy.re): A Library for Gaussian Processes and Variational Inference
Submitting author: @Edenhofer
Handling editor: @dfm (Active)
Reviewers: @Abinashbunty, @apizzuto
Similarity score: 0.6603

flowMC: Normalizing flow enhanced sampling package for probabilistic inference in JAX
Submitting author: @kazewong
Handling editor: @rkurchin (Active)
Reviewers: @matt-graham, @Daniel-Dodd
Similarity score: 0.6589

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@srigas
Copy link

srigas commented Jan 28, 2025

@srigas while I try to rustle up some reviewers for this, please take a look at the DOI the bot found (see above) and see if it's the right one for your reference. if so, please add it to your bib-file.

@fabian-s Thank you, that was an omission on my part, I fixed it! 👍🏻

@kazewong
Copy link

Thanks for the suggestion but I won't be available for review until late February.

@jeremiecoullon
Copy link

Hello! Unfortunately I'm not free to work on this review

@fabian-s
Copy link

👋 @daniel-dodd @KindXiaoming @canyon289 @ColCarroll

would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@fabian-s
Copy link

👋 @daniel-dodd @KindXiaoming @canyon289 @ColCarroll

would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Even if not, it would be kind of you to reply so I can ask somebody else.

@fabian-s
Copy link

@kazewong would you still be willing to review this? as you can see we have a hard time finding competent reviewers for this...

@kazewong
Copy link

@fabian-s I should be able to review this repo. Just keep in mind I have another ongoing JOSS review so the turn around time will be a bit longer.

@fabian-s
Copy link

@kazewong that's fine, thanks!

@fabian-s
Copy link

@editorialbot add @kazewong as reviewer

@editorialbot
Copy link
Collaborator Author

Can't add reviewers: There is no editor assigned yet

@fabian-s
Copy link

@editorialbot add @fabian-s as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @fabian-s is now the editor

@fabian-s
Copy link

@editorialbot add @kazewong as reviewer

@editorialbot
Copy link
Collaborator Author

@kazewong added to the reviewers list!

@kazewong
Copy link

@editorialbot generate my checklist

@editorialbot
Copy link
Collaborator Author

Checklists can only be created once the review has started in the review issue

@ColCarroll
Copy link

hey @fabian-s -- I can review. apologies for the slow response!

@fabian-s
Copy link

@editorialbot add @ColCarroll as reviewer

@editorialbot
Copy link
Collaborator Author

@ColCarroll added to the reviewers list!

@fabian-s
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7830.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

7 participants