From c71be06b0107431fc8f8784a35f8601a3ce7b5d7 Mon Sep 17 00:00:00 2001
From: Joseph Muller <j.muller@bbk.ac.uk>
Date: Wed, 29 Jan 2025 13:13:03 +0000
Subject: [PATCH] fix #4299 Hide downloads if no downloadable galleys

---
 src/themes/OLH/templates/journal/article.html | 31 ++++++++++---------
 .../clean/templates/journal/article.html      |  4 ++-
 .../material/templates/journal/article.html   | 14 +++++----
 3 files changed, 28 insertions(+), 21 deletions(-)

diff --git a/src/themes/OLH/templates/journal/article.html b/src/themes/OLH/templates/journal/article.html
index 032dda760..3acb3714b 100644
--- a/src/themes/OLH/templates/journal/article.html
+++ b/src/themes/OLH/templates/journal/article.html
@@ -233,26 +233,29 @@ <h2>{% trans "Publisher Notes" %}</h2>
                                 {% if article.is_published or proofing %}
                                     {% if not request.journal.disable_metrics_display %}
                                         <div class="top">
-                                            <div class="row">
-                                                <div class="large-{% if article.citation_count and not journal_settings.article.suppress_citations_metric %}4{% else %}6{% endif %} columns">
+                                            <div class="flex">
+                                                <div class="columns">
                                                     <p class="number">
                                                         {{ article.metrics.views }}
                                                         <span>{% trans "Views" %}</span>
                                                     </p>
                                                 </div>
-                                                <div class="large-{% if article.citation_count and not journal_settings.article.suppress_citations_metric %}4{% else %}6{% endif %} columns">
-                                                    <p class="number">
-                                                        {{ article.metrics.downloads }}
-                                                        <span>{% trans "Downloads" %}</span>
-                                                    </p>
-                                                </div>
+
+                                                {% if galleys %}
+                                                    <div class="columns">
+                                                        <p class="number">
+                                                            {{ article.metrics.downloads }}
+                                                            <span>{% trans "Downloads" %}</span>
+                                                        </p>
+                                                    </div>
+                                                {% endif %}
                                                 {% if article.citation_count and not journal_settings.article.suppress_citations_metric %}
-                                                <div class="large-4 columns">
-                                                    <p class="number">
-                                                        {{ article.citation_count }}
-                                                        <span>{% trans "Citations" %}</span>
-                                                    </p>
-                                                </div>
+                                                    <div class="columns">
+                                                        <p class="number">
+                                                            {{ article.citation_count }}
+                                                            <span>{% trans "Citations" %}</span>
+                                                        </p>
+                                                    </div>
                                                 {% endif %}
                                             </div>
                                         </div>
diff --git a/src/themes/clean/templates/journal/article.html b/src/themes/clean/templates/journal/article.html
index cd369b1e2..b1d46c25c 100644
--- a/src/themes/clean/templates/journal/article.html
+++ b/src/themes/clean/templates/journal/article.html
@@ -288,7 +288,9 @@ <h2>{% trans "Open Peer Reviews" %}</h2>
                     <h2>{% trans "Metrics" %}</h2>
                     <ul>
                         <li>{% trans "Views" %}: {{ article.metrics.views }}</li>
-                        <li>{% trans "Downloads" %}: {{ article.metrics.downloads }}</li>
+                        {% if galleys %}
+                            <li>{% trans "Downloads" %}: {{ article.metrics.downloads }}</li>
+                        {% endif %}
                         {% if article.metrics.alm.twitter %}
                             <li>{% trans "Twitter" %}: {{ article.metrics.alm.twitter }}</li>{% endif %}
                         {% if article.metrics.alm.wikipedia %}
diff --git a/src/themes/material/templates/journal/article.html b/src/themes/material/templates/journal/article.html
index 3283b7f9d..543fca086 100644
--- a/src/themes/material/templates/journal/article.html
+++ b/src/themes/material/templates/journal/article.html
@@ -162,12 +162,14 @@ <h5>
                                     </h5>
                                     <p><i class="fa fa-eye"></i>{% trans "Views" %}</p>
                                 </div>
-                                <div class="alm">
-                                    <h5>
-                                        {{ article.metrics.downloads }}
-                                    </h5>
-                                    <p><i class="fa fa-download"></i>{% trans "Downloads" %}</p>
-                                </div>
+                                {% if galleys %}
+                                    <div class="alm">
+                                        <h5>
+                                            {{ article.metrics.downloads }}
+                                        </h5>
+                                        <p><i class="fa fa-download"></i>{% trans "Downloads" %}</p>
+                                    </div>
+                                {% endif %}
                                 {% if article.metrics.alm.twitter %}
                                     <div class="alm">
                                         <h5>