Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Unit Tests First in CI #2828

Open
tjlaboss opened this issue Jan 10, 2024 · 3 comments · May be fixed by #3163
Open

Run Unit Tests First in CI #2828

tjlaboss opened this issue Jan 10, 2024 · 3 comments · May be fixed by #3163

Comments

@tjlaboss
Copy link
Contributor

Description

I noticed that regression tests are run before unit tests in the OpenMC continuous integration.

Currently, it takes ~40 minutes to run the CI testing. Most of that time is spent on the regression tests--seems like errors could be caught faster if the unit tests were run first.
@MicahGale
Copy link
Contributor

Specifically you want python unit tests to be ran first?

Probably not the right venue, but also preserving test reports (e.g., test.xml) is much more helpful for debugging.

@gonuke
Copy link
Contributor

gonuke commented Oct 5, 2024

I think this is just based on the alphabetical order of the directory names

@gonuke gonuke linked a pull request Oct 5, 2024 that will close this issue
Draft
5 tasks
@MicahGale
Copy link
Contributor

I can't find any documentation confirming this, but anecdotally pytest does run test files in alphabetical. There are some tools to manually order tests, but this seems like too hard code-y.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Swap test order gonuke/openmc
3 participants
@gonuke @MicahGale @tjlaboss