-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding location and command for the various forms of components #7
Comments
a) points to the source code repo but would never be actually usable to download/build/invoke a component. Pointing to "master" is usually a bad idea since it is a moving target. Better would be to point to a release ZIP. IMHO there is a difference between the repo location and a source distribution. Cf.
c) is lacking version information - afaik it is usually provided by appending ":" and the version number to the image name I don't understand why a difference is made between c) and d). In f), do we really need separate entries for the dockerized/galaxy versions? |
Should there be an e)? |
For a) Thanks @reckart for the explanations; these will come handy as tips in the guidelines. Just keep in mind that all these were meant as an example. |
wrt f) and d): I still don't see what the difference is between "a docker image" and "a galaxy docker image" - why should it not be possible to run a docker image in another workflow system instead of Galaxy? |
Of course it's possible, but (at least the way it was done for the demo), the galaxy id was required for running the workflows; so, in a similar way to having the docker id stored in the metadata, I need to predict the same info for the galaxy id. The examples are meant to check that this can be done for the various scenarios - they don't all have to be filled in. |
Why do we need separate IDs? In which way does a "docker" and a "galaxyDocker" docker image differ? |
Sorry, it was a mixup of a couple of examples together - one for a dockerised component/web service and a separate one for workflows. The galaxy id is required only for workflows which are composed of more than one components (aka. docker images). |
Ok, I think I got it. Then I would propose |
In the demo experiment, we have been using the resourceIdentifier for the location and/or command used to run components and workflows, but this is not safe.
The proposal is to use for this reason the "componentLoc" with the following changes:
In this way we can handle the following examples:
a) components at github:
b) components at Maven
c) docker images
d) components dockerised and in galaxy
f) web services, their dockerised images and wrapped in Galaxy
Could @antleb @courado and @reckart check and let me know if I've missed something?
The text was updated successfully, but these errors were encountered: