Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading data does not work from the local website #2

Open
josvandervelde opened this issue Feb 23, 2024 · 1 comment
Open

Downloading data does not work from the local website #2

josvandervelde opened this issue Feb 23, 2024 · 1 comment

Comments

@josvandervelde
Copy link
Collaborator

Reproduction

  1. Run the docker compose.
  2. Go to a dataset
  3. Click on "download" (top right)

Actual

ns_error_unknown_host

Expected

Download a dataset file

Reason

The files stored on MinIO needs to be accessible from

  1. other containers (for instance, to run the evaluation engine)
  2. the user (from the website)

For the former, the minio url needs to be an url with which a pod on K8s can communicate with the MinIO pod. This is "http://minio:9000". For the second, the url should be http://localhost:9000. Because we store the url in the db, we have to choose one of them for now.

Possible solutions

  1. Don't store the complete url in the db
  2. ...
@PGijsbers
Copy link
Contributor

nitpick: minio url is not hard-coded in the database, but instead in the PHP code, if I am not mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants