-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(refactor) O3-3326 Patient Search - migrate to use workspace from core #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -52.5 kB (-0.8%) Total Size: 6.49 MB
ℹ️ View Unchanged
|
brandones
approved these changes
Nov 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, great improvement. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Currently, the only way to include patient search functionality into other apps (like service queues) is to use the
patient-search-button
extension, which opens its own non-standard overlay for the search UI.This PR changes that overlay into a standard workspace that can be opened with a
launchWorkspace
call from other apps.The
PatientSearchOverlay
is still a component that's used in tablet mode in:/openmrs/spa/search
(upon closing the overlay, the user is redirected to home page)Since that behavior is somewhat different that a regular workspace, the
PatientSearchOverlay
is retained.Screenshots
Tablet mode:
https://github.com/user-attachments/assets/e9c36bb3-8ed4-4b91-832d-88c75d9df779
Desktop mode:
https://github.com/user-attachments/assets/7c684cd4-e9db-4ca1-b0dc-395f40d9f24c
Related Issue
https://openmrs.atlassian.net/browse/O3-3326
Other