Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLAG-67: Fix rendering of flags via simple objects that is currently broken in platform version greater than 2.5.* #82

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

ManojLL
Copy link
Contributor

@ManojLL ManojLL commented Jul 12, 2024

Description of what I changed

fixed the patient flags rendering issue on platform lower versions

Issue I worked on

see https://openmrs.atlassian.net/browse/FLAG-67

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

FLAG-67: fixed flag rendering on platform lower versions

FLAG-67: change code styles
@ManojLL ManojLL changed the title FLAG-67: fixed flag rendering on platform lower versions FLAG-67: Fix rendering of flags via simple objects that is currently broken in platform version greater than 2.5.* Jul 12, 2024
@dkayiwa dkayiwa merged commit b130932 into openmrs:master Jul 14, 2024
3 checks passed
ManojLL added a commit to ManojLL/openmrs-module-patientflags that referenced this pull request Jul 20, 2024
FLAG-67: fixed flag rendering on platform lower versions

FLAG-67: change code styles
ManojLL added a commit to ManojLL/openmrs-module-patientflags that referenced this pull request Jul 22, 2024
FLAG-67: fixed flag rendering on platform lower versions

FLAG-67: change code styles
ManojLL added a commit to ManojLL/openmrs-module-patientflags that referenced this pull request Jul 22, 2024
FLAG-67: fixed flag rendering on platform lower versions

FLAG-67: change code styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants