Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test » validate the AEMO file & formats #8

Open
jufemaiz opened this issue Jan 7, 2019 · 0 comments
Open

Integration test » validate the AEMO file & formats #8

jufemaiz opened this issue Jan 7, 2019 · 0 comments

Comments

@jufemaiz
Copy link
Contributor

jufemaiz commented Jan 7, 2019

A base assumption of the nemweb library is the expected files & formats on the nemweb file server(s).

Shifting to using HTTP mocks with fixtures (ref: #7) will mean the current test breakages caused by both file & format changes and/or intermittent issues with nemweb won't be visible. Thus it is advisable to include integration tests that ensure the assumptions remain correct.

Questions:

  • should there be live integration tests?
  • should they be run on PRs? (Note: travis or similar to be set up)
  • should they break a build?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant