Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean and Refactor app repo #157

Open
remicolin opened this issue Jul 26, 2024 · 20 comments
Open

Clean and Refactor app repo #157

remicolin opened this issue Jul 26, 2024 · 20 comments

Comments

@remicolin
Copy link
Member

remicolin commented Jul 26, 2024

Few things in order of importance:

  • clean and refactor MainScreen.tsx
  • migrate most of the complex functions from app/src/utils to common repo
  • clean/refactor of other app/src files of the repo
  • create custom tamagui components/styles to have cleaner code

this has to be done from branch "new-ux"

@remicolin remicolin added good first issue Good for newcomers easy ODHack and removed good first issue Good for newcomers labels Jul 26, 2024
@stevencartavia
Copy link

Hi, I would like to try this!

@remicolin
Copy link
Member Author

hi, you can start working on it

@KodeSage
Copy link

Hi @remicolin , I will love to work on this. if No one is working in on it.

Duration of Completion is One Day.

Copy link

onlydustapp bot commented Jul 29, 2024

Hi @KodeSage!
Maintainers during the ODHack #6.0 will be tracking applications via OnlyDust.
Therefore, in order for you to have a chance at being assigned to this issue, please apply directly here, or else your application may not be considered.

@martinvibes
Copy link

martinvibes commented Jul 29, 2024

i am applying this issue via https://app.onlydust.com/p/proof-of-passport

My background and how it can be leveraged

i'm a fronten dev and i have experiene in javasript, react, typescript and tailwind css
hi @remicolin let me hop on this issue and get it done.

I would love to work on this and be a contributor on this repo

Copy link

onlydustapp bot commented Jul 29, 2024

Hi @martinvibes!
Maintainers during the ODHack #6.0 will be tracking applications via OnlyDust.
Therefore, in order for you to have a chance at being assigned to this issue, please apply directly here, or else your application may not be considered.

1 similar comment
Copy link

onlydustapp bot commented Jul 29, 2024

Hi @martinvibes!
Maintainers during the ODHack #6.0 will be tracking applications via OnlyDust.
Therefore, in order for you to have a chance at being assigned to this issue, please apply directly here, or else your application may not be considered.

@BernalHQ
Copy link
Contributor

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hello, my name is Bernal. I am a software developer from Costa Rica. Currently, I work as a back-end developer. In my previous job, I worked as a full-stack developer. Personally, I enjoy developing both the back end and the front end. I have 4 years of experience in the software development industry. Some technologies I have worked with include: Typescript, React, C#, and Node.

How I plan on tackling this issue

To reach the solution, the first step is to understand how the project works. This involves familiarizing yourself with the project's documentation, structure, and codebase. Next, thoroughly review the issue description to grasp the problem fully. Based on this understanding, brainstorm and propose a viable solution. Once you have a clear plan, implement the solution in the code. After coding, conduct comprehensive tests to ensure the fix resolves the issue without introducing new problems. Finally, review your changes and prepare them for submission, ensuring all aspects of the issue have been addressed effectively.

@vnitin08
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hey, I'm Nitin a Fullstack typescript and Blockchain developer. I am learning ZK for the past few months and i want to explore more about it and also want to understand its application in real world.

How I plan on tackling this issue

I had written good quality and modular code for startups. Basically i will try refactor as mentioned the issue

@juandiegocv27
Copy link

juandiegocv27 commented Jul 29, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I'm Juan Diego Carballo, a Full-Stack Web Developer proficient in TypeScript, Java, Rust, and Unity, currently enrolled in the PSE Core Program. I'm eager to apply my technical skills and recent training to the "proof-of-passport" project by undertaking the cleanup and refactoring of the app repository. I have actively participated in events like StarkHack and a hackerhouse in Brussels, enhancing my capability to tackle real-world tech challenges. My projects can be viewed on my GitHub Profile and OnlyDust Profile. Plus I´m active member of Dojo Coding community 🇨🇷.

How I plan on tackling this issue

Proposed Approach:

MainScreen Refactor: Start by cleaning and refactoring MainScreen.tsx, ensuring the code is readable, maintainable, and efficient.
Function Migration: Migrate complex functions from app/src/utils to the common repository to improve modularity and reusability across the project.
General Cleanup: Perform a thorough cleanup and refactor of other files in app/src to align with best coding practices.
Custom Components: Create custom Tamagui components and styles to simplify and enhance the codebase, contributing to a more maintainable structure.
I am committed to leveraging my comprehensive skills to enhance the maintainability and performance of the Proof of Passport application, particularly from my recent learning experiences in the PSE Core Program. I look forward to making a meaningful contribution to this project.

Copy link

onlydustapp bot commented Jul 29, 2024

Hi @martinvibes!
Maintainers during the ODHack #6.0 will be tracking applications via OnlyDust.
Therefore, in order for you to have a chance at being assigned to this issue, please apply directly here, or else your application may not be considered.

@stevencartavia
Copy link

hi, you can start working on it

Hi, Unfortunately, due to an unexpected situation that has come up, I won't be able to complete the issue within the expected timeframe. I apologize for any inconvenience this may cause.

@Dedigraz
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Worked in lots of big node, rust, swift, c++ and java projects and have been in many big refactoring projects.

How I plan on tackling this issue

I would first do a passthrough of the source code mark any inconsistencies or issues I can spot then pass it through a set of code quality checkers, linters and some code readability and complexity algorithms.

@JoelVR17
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Clean and Refactor

Hello Proof Password team,

I am Joel Vargas, and I'm member of Dojo Coding. I also come from OnlyDust

How I plan on tackling this issue

Refactoring Plan for MainScreen.tsx

  1. Review Current Code

    • Carefully read MainScreen.tsx and files in app/src/utils to understand their functionality.
    • Identify and document complex functions.
  2. Migrate Complex Functions

    • Create a common repository if it doesn't exist.
    • Move complex functions from app/src/utils to the common repository and update imports.
  3. Refactor MainScreen.tsx

    • Break down the code into smaller, reusable components.
    • Clean up the code by removing duplicates and outdated comments.
    • Ensure logical structure and descriptive names for variables and functions.
  4. Refactor Other Files in app/src

    • Review and clean up code in other files within app/src.
    • Align the code with best practices and the new structure.
  5. Create Custom Tamagui Components/Styles

    • Identify the need for custom components and styles.
    • Develop and integrate these custom components using Tamagui.
  6. Testing and Verification

    • Conduct unit and integration tests.
    • Request a peer review to ensure code quality.
  7. Documentation and Pull Request

    • Update project documentation.
    • Submit a pull request to the new-ux branch.

This plan outlines my approach to refactoring and cleaning up MainScreen.tsx to improve the project's code quality and structure.

I am willing to follow any specific guidelines the team may have. I appreciate the opportunity to contribute and am ready to start as soon as the issue is assigned to me.

Also, if you need, you can contact me by Telegram

Thank you!

@PoulavBhowmick03
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a fullstack blockchain developer with 2 years of experience

How I plan on tackling this issue

I would go to the MainScreen.tsx, migrate the complex functions as asked to utils and clean the other files to import and use this common repo

@DavidOredu
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Experience in C# for Unity game development.
Experience in Python.

@pheobeayo
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a web3 frontend developer skilled in both typescript and Javascript
I style with Tailwind CSS, material UI, styled components, SCSS and Chakra UI

How I plan on tackling this issue

I will tackle the problem by
running through the code
Refractor the main screen and implement the changes
integrate the functions into the common repo
clean up other files in the repo
remove unnecessary codes to have well-written codes

@Psalmuel01
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hello, I'm Samuel Dahunsi. I am a passionate web3 frontend engineer with extensive experience in JavaScript, React, and Next.js. I have built several Web3 projects, and won a couple hackathons. I also write secure and scalable smart contracts in Solidity for the Ethereum ecosystem. Been in the space for two years.

My skills in both frontend development and blockchain technology will ensure high-quality, clean, and maintainable code for this task. I am also very effective and fast, and love to do a perfect work.

Looking forward to contributing!

How I plan on tackling this issue

Here is my plan of action:

Clean and Refactor MainScreen.tsx:

Review the current implementation to identify areas for improvement.
Refactor the code to improve readability, maintainability, and performance.
Ensure the component follows best practices and is optimized for efficiency.
Migrate Complex Functions from app/src/utils to the Common Repo:

Identify and document the complex functions in app/src/utils.
Create a new module in the common repository to house these functions.
Refactor the code to ensure seamless integration with the existing codebase and update imports accordingly.
Clean and Refactor Other Files in app/src:

Conduct a thorough review of the remaining files in app/src.
Apply consistent coding standards and best practices across the codebase.
Optimize the code for better performance and maintainability.
Create Custom Tamagui Components/Styles:

Identify recurring patterns and styles that can be abstracted into reusable Tamagui components.
Develop custom components and styles to ensure cleaner, more maintainable code.
Replace existing implementations with the new custom components and styles to maintain consistency.

@od-hunter
Copy link

od-hunter commented Oct 10, 2024

Hi @remicolin , can I work on this please?
ETA- less than 48 hours

@Kaminar-i
Copy link

i'm a frontend dev and i have experience in javasript, react, typescript and tailwind css
hi @remicolin let me hop on this issue and get it done.

I would love to work on this and be a contributor on this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests