Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding holidays for Portugal #26

Closed
fstueber opened this issue Sep 5, 2023 · 3 comments
Closed

Adding holidays for Portugal #26

fstueber opened this issue Sep 5, 2023 · 3 comments
Labels
new data New holiday data is available

Comments

@fstueber
Copy link
Contributor

fstueber commented Sep 5, 2023

Initial data provided by @48design:
https://github.com/openpotato/openholidaysapi.data/tree/feature/pt/src/pt

@fstueber
Copy link
Contributor Author

fstueber commented Sep 5, 2023

Question to @48design:

  • According to Wikipedia municipal holidays in Portugal are optional, that is, they can be observed by companies but not necessarily. Should we really put them as public holidyays to the database?

@48design
Copy link

48design commented Sep 6, 2023

We could either set the Type column to Optional, or put them in a new file together, like holidays.optional.csv?

@fstueber
Copy link
Contributor Author

fstueber commented Sep 6, 2023

Yes, maybe. They definitely need another type. Will think about that. There is a request #10 for adding non-statutory holidays, which is similar

@fstueber fstueber added new data New holiday data is available and removed enhancement New feature or request labels Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new data New holiday data is available
Projects
None yet
Development

No branches or pull requests

2 participants