Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review results #47

Open
rcannood opened this issue Jan 24, 2025 · 3 comments
Open

Review results #47

rcannood opened this issue Jan 24, 2025 · 3 comments

Comments

@rcannood
Copy link
Member

There is still a run in progress, will update when these results come in.


The HVG overlap metric isn't giving meaningful results -- possibly related to #46. Until this is fixed, we should remove the HVG overlap


We could have three plots in three different tabs:

  • All methods but only graph metrics
  • Embed + feature methods, graph + embed metrics
  • Only feature methods, all metrics

Or we could have one plot but with three different summary metrics:

  • A label indicating whether the model is able to output a feature matrix, an embedding, or graph metrics
  • Average score across graph metrics
  • Average score across embedding metrics
  • Average score across feature metrics

Check PCR metric: according to the normalization plot, the feature-type methods seem to be getting a near perfect score. It might be comparing something it shouldn't be comparing.

@DarioS
Copy link

DarioS commented Feb 3, 2025

Also, the algorithms evaluated are pre-COVID era. Why are only outdated methods being evaluated?

"method_name": "Combat (full/scaled)",
"paper_year": 2007,
    ...        ...
"method_name": "FastMNN feature (full/scaled)",
"paper_year": 2019,
    ...        ...
"method_name": "Scanorama gene output (full/scaled)",
"paper_year": 2019,

@rcannood
Copy link
Member Author

rcannood commented Feb 3, 2025

We've been working on a revision for this task for a while now. A preview of these results is available at https://foundation-models-results--openproblems.netlify.app/results/batch_integration/. They will be released any day now.

We're also working on a new website, which will allow us to render pre-release results on the website itself: https://openproblems-bio.deno.dev/.

If there are batch integration methods which you believe should be added to this task, feel free to create a separate github issue for each of those methods, or follow the instructions on how to add a method.

@DarioS
Copy link

DarioS commented Feb 4, 2025

Ah, good coincidence! I see lots of contemporary methods are incorporated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants