Flow between two methods marks two sources instead of one

[BoykoAlex]

See below:

import java.util.LinkedList;
class Test {
    void test() {
        Integer x = Integer.parseInt("10");
        LinkedList<Integer> l = /*~~(source)~~>*/new LinkedList<>();
        LinkedList<Integer> m = /*~~(source)~~>*/new LinkedList<>();
        System.out.println(x);
        System.out.println(m);
        System.out.println(/*~~>*/l);
        /*~~(sink)~~>*/l.remove();
    }
}

The test is:

    @Test
    void taintFlowBetweenArgumentsAndSubject_FakeSource() {
        rewriteRun(
          spec -> spec.recipe(new FindFlowBetweenMethods(
              "java.util.LinkedList <constructor>()",
              true,
              "java.util.LinkedList remove()",
              true,
              "Both",
              "Taint"
            )
          ),
          //language=java
          java(
            """
              import java.util.LinkedList;
              class Test {
                  void test() {
                      Integer x = Integer.parseInt("10");
                      LinkedList<Integer> l = new LinkedList<>();
                      LinkedList<Integer> m = new LinkedList<>();
                      System.out.println(x);
                      System.out.println(m);
                      System.out.println(l);
                      l.remove();
                  }
              }
              """,
            """
              import java.util.LinkedList;
              class Test {
                  void test() {
                      Integer x = Integer.parseInt("10");
                      LinkedList<Integer> l = /*~~(source)~~>*/new LinkedList<>();
                      LinkedList<Integer> m = new LinkedList<>();
                      System.out.println(x);
                      System.out.println(m);
                      System.out.println(/*~~>*/l);
                      /*~~(sink)~~>*/l.remove();
                  }
              }
              """
          )
        );
    }

[timtebeek]

Ah wow, that's a bug indeed, thanks for reporting it. Had you already explored a cause?

[BoykoAlex]

I've tried during the holidays but gave that up ;-) Going away for a week now. If you'd like me to get to the bottom of it let me know - I can resume my investigation upon return.
I also tried to reproduce the issue with the Gradle build file with the same recipe but my unit test has passed so far... (if you recall i had an issue with Gradle build file with the same recipe... just couldn't convert my issue into a unit test yet ;-)

[timtebeek]

Thanks and enjoy your time off first! I must say I'm not too familiar with the code here, but perhaps @JLLeitschuh can provide some guidance (although he's traveling as well). Any help appreciated. What's the wider use case you're after here? Perhaps there's alternatives still.

[JLLeitschuh]

Fascinating! I have no idea what's going on here. I'd need to fire up the debugger to drill into what's going on here.