[22] coll3's ListUtils.EMPTY_LIST -> to java's Collections.emptyList (#…

…23) #22 Co-authored-by: Samuel Cox <[email protected]>
openrewrite · Aug 6, 2024 · db959db · db959db
1 parent 75ca72c
commit db959db
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/main/resources/META-INF/rewrite/apache-commons-collections-3-4.yml b/src/main/resources/META-INF/rewrite/apache-commons-collections-3-4.yml
@@ -46,6 +46,11 @@ recipeList:
       oldFieldName: EMPTY_MAP
       newClassName: java.util.Collections
       newMethodName: emptyMap
+  - org.openrewrite.java.ChangeStaticFieldToMethod:
+      oldClassName: org.apache.commons.collections.ListUtils
+      oldFieldName: EMPTY_LIST
+      newClassName: java.util.Collections
+      newMethodName: emptyList
   - org.openrewrite.java.ChangePackage:
       oldPackageName: org.apache.commons.collections
       newPackageName: org.apache.commons.collections4
diff --git a/...a/org/openrewrite/apache/commons/collections/UpgradeApacheCommonsCollections_3_4Test.java b/...a/org/openrewrite/apache/commons/collections/UpgradeApacheCommonsCollections_3_4Test.java
@@ -46,9 +46,11 @@ void apacheCommonsCollections() {
             """
               import org.apache.commons.collections.CollectionUtils;
               import org.apache.commons.collections.map.IdentityMap;
+              import org.apache.commons.collections.ListUtils;
               import org.apache.commons.collections.MapUtils;
               import org.apache.commons.collections.FastArrayList;
 
+              import java.util.List;
               import java.util.Map;
 
               class Test {
@@ -58,6 +60,7 @@ static void helloApacheCollections() {
                       IdentityMap identityMap = new IdentityMap();
                       Map emptyMap = MapUtils.EMPTY_MAP;
                       FastArrayList fastList = new FastArrayList(100);
+                      List emptyList = ListUtils.EMPTY_LIST;
                   }
               }
               """,
@@ -66,6 +69,7 @@ static void helloApacheCollections() {
 
               import java.util.Collections;
               import java.util.IdentityHashMap;
+              import java.util.List;
               import java.util.Map;
               import java.util.concurrent.CopyOnWriteArrayList;
 
@@ -76,6 +80,7 @@ static void helloApacheCollections() {
                       IdentityHashMap identityMap = new IdentityHashMap();
                       Map emptyMap = Collections.emptyMap();
                       CopyOnWriteArrayList fastList = new CopyOnWriteArrayList(100);
+                      List emptyList = Collections.emptyList();
                   }
               }
               """