Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnnotationMatcher doesn`t work in kotlin #466

Closed
jeonyeonbin opened this issue Nov 27, 2023 · 5 comments
Closed

AnnotationMatcher doesn`t work in kotlin #466

jeonyeonbin opened this issue Nov 27, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@jeonyeonbin
Copy link

Hi, i send bug report in rewrite-kotlin
While using AnnotationMatcher, I think I found a bug that doesn't work only in Kotlin.

If you check the JavaType when using Kotlin,
It appears as JavaType$Method, and when using java, it appears as JavaType$Class.

in AnnotationMatcher method matchesAnnotationName got false in kotlin.
can u help me?

image
@jeonyeonbin jeonyeonbin added the bug Something isn't working label Nov 27, 2023
@timtebeek timtebeek moved this to Backlog in OpenRewrite Nov 27, 2023
@timtebeek
Copy link
Contributor

That seems like a bug indeed; would you be open to creating a draft pull request that adds a test for this recipe here? That way we can run the above in a debugger from the unit test and look at what's needed for a fix.

@jeonyeonbin
Copy link
Author

jeonyeonbin commented Nov 27, 2023

i add sample code in

@traceyyoshima
Copy link
Contributor

Hi @jeonyeonbin, thank you for reporting the issue and providing a test -- we'll fix it shortly :)

@jbellenger
Copy link

Hi! Thanks for fixing this! I'm running in to the same issue, do you have an ETA for the next release?

@timtebeek
Copy link
Contributor

Hi @jbellenger ; we typically do a full release train every two weeks or so, with occasional patch releases in between, provided there's no dependencies on upstream changes (which I think there might be just now). Tracey can probably best tell you if and when we can do a release of rewrite-kotlin specifically, and the downstream plugins following that. If you want to try this out in the meantime it's best to use our snapshot versions. Hope that helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment