-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlin source files under src/main/java should be detected #936
Labels
bug
Something isn't working
Comments
3 tasks
reisners
added a commit
to reisners/rewrite-maven-plugin
that referenced
this issue
Jan 25, 2025
… for Kotlin sources in src/*/java instead
reisners
added a commit
to reisners/rewrite-maven-plugin
that referenced
this issue
Jan 28, 2025
…otlinTestSourceDir (was kotlinSourceDir)
reisners
added a commit
to reisners/rewrite-maven-plugin
that referenced
this issue
Jan 28, 2025
reisners
added a commit
to reisners/rewrite-maven-plugin
that referenced
this issue
Jan 28, 2025
reisners
added a commit
to reisners/rewrite-maven-plugin
that referenced
this issue
Jan 28, 2025
reisners
added a commit
to reisners/rewrite-maven-plugin
that referenced
this issue
Jan 28, 2025
…o two independent testcases
reisners
added a commit
to reisners/rewrite-maven-plugin
that referenced
this issue
Jan 28, 2025
MBoegers
added a commit
that referenced
this issue
Jan 28, 2025
…a if src/*/kotlin does not exist (#937) * add test case which fails initially because 0 kotlin source files will be found in the non-existent src/main/kotlin * minor cleanup * intentionally mess up formatting * #936 in case of missing src/*/kotlin fall back to scanning for Kotlin sources in src/*/java instead * #936 rename variable in processTestSources more aptly to kotlinTestSourceDir (was kotlinSourceDir) * #936 refactor listKotlinSources() * #936 also verify that Kotlin source files are found unter src/test/java * #936 fix debug log message * #936 separate tests of src/main/java and src/test/java into two independent testcases * #936 removed @NotNull annotation and annotated package as @NullMarked * polishing with best practices subset --------- Co-authored-by: Merlin Bögershausen <[email protected]>
@reisners could you retest with your local build plugin and briefly report the result? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of OpenRewrite are you using?
I am using
How are you running OpenRewrite?
I am using the Maven plugin, and my project is a single module project.
What is the smallest, simplest way to reproduce the problem?
Given Kotlin source file
src/main/java/sample/MyClass.kt
with content below,and the
kotlin-maven-plugin
configured as follows,invoking the
Autoformat
recipe using this command lineWhat did you expect to see?
The Kotlint source file
src/main/java/sample/MyClass.kt
should have been detected and reformatted intoWhat did you see instead?
The Kotlin source file at
src/main/java/sample/MyClass.kt
was not detected and therefore not reformatted.What is the full stack trace of any errors you encountered?
There was no error.
Are you interested in contributing a fix to OpenRewrite?
Yes, I am preparing a PR with a fix.
The text was updated successfully, but these errors were encountered: