Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guava com.google.common.base.Charsets to StandardCharsets #101

Closed
yeikel opened this issue Apr 27, 2022 · 3 comments
Closed

Guava com.google.common.base.Charsets to StandardCharsets #101

yeikel opened this issue Apr 27, 2022 · 3 comments
Labels
good first issue Good for newcomers recipe Recipe requested

Comments

@yeikel
Copy link
Contributor

yeikel commented Apr 27, 2022

See : https://guava.dev/releases/20.0/api/docs/com/google/common/base/Charsets.html

Also openrewrite/rewrite-apache#4 and openrewrite/rewrite#1724
@pway99
Copy link
Contributor

pway99 commented Apr 27, 2022

for reference

rewrite-migrate-java/src/main/resources/META-INF/rewrite/apache-commons-io.yml

Line 45 in 79cb372

name: org.openrewrite.java.migrate.apache.commons.io.UseStandardCharsets

@pway99 pway99 added the recipe Recipe requested label Apr 27, 2022
@pway99 pway99 moved this to Recipes Wanted in OpenRewrite Apr 27, 2022
@timtebeek timtebeek added the good first issue Good for newcomers label Mar 23, 2023
@koppor koppor mentioned this issue Oct 12, 2023
Closed
@tobli
Copy link
Contributor

tobli commented Jan 2, 2024

I believe this is already covered by org.openrewrite.java.migrate.guava.PreferJavaNioCharsetStandardCharsets

@timtebeek
Copy link
Contributor

timtebeek commented Jan 24, 2024 •
edited
Loading

Indeed; thanks for pointing that out! Fixed in

@github-project-automation github-project-automation bot moved this from Recipes Wanted to Done in OpenRewrite Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers recipe Recipe requested
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tobli @timtebeek @yeikel @pway99