Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major adjustments to recipes with certain licenses #147

Closed
mike-solomon opened this issue Dec 17, 2024 · 2 comments · Fixed by #151
Closed

Major adjustments to recipes with certain licenses #147

mike-solomon opened this issue Dec 17, 2024 · 2 comments · Fixed by #151
Assignees
Labels
enhancement New feature or request

Comments

@mike-solomon
Copy link
Contributor

mike-solomon commented Dec 17, 2024

We need to make significant changes to recipes based on their licenses. Any recipes that are proprietary to Moderne should have most of their instructions removed (except for the CLI) and shouldn't have any YAML stuff. They also should have information about how to become a Moderne customer to get the recipes.

We also need to figure out if there are any additional recipes to include that we aren't already -- and how we can securely get the information for all of this.

Additional context in the Moderne Slack: https://moderneinc.slack.com/archives/C01VADFPJQZ/p1733866200482319

@mike-solomon mike-solomon added the enhancement New feature or request label Dec 17, 2024
@timtebeek timtebeek moved this to Backlog in OpenRewrite Dec 18, 2024
@timtebeek timtebeek moved this from Backlog to In Progress in OpenRewrite Dec 18, 2024
@timtebeek
Copy link
Contributor

I'd say this is mostly done by now, but you're welcome to keep it open if that helps you keep track of the last tasks.

@mike-solomon
Copy link
Contributor Author

I’ll keep this open for now as I think there’s still quite a few more things to do unless I’ve missed something.

Things I am thinking about include:

  • Making a license section or note in the individual recipe pages.
  • Removing links to github or issues for recipes that are proprietary as they will just result in 404s for people.
  • Cleaning up instructions to say that certain recipes can only be used if you’re a Moderne customer.

@mike-solomon mike-solomon self-assigned this Dec 19, 2024
mike-solomon added a commit that referenced this issue Dec 19, 2024
mike-solomon added a commit that referenced this issue Dec 20, 2024
* Adjust recipe details based on license

Fixes: #147

* Minor rephrasing

* Cleanup code

---------

Co-authored-by: Mike Solomon <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenRewrite Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants