Replace Validate.notNull(String) as well (#458)

Fixes #457
openrewrite · Feb 7, 2025 · 134cc38 · 134cc38
1 parent 09ea6c0
commit 134cc38
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 3 deletions.
diff --git a/src/main/resources/META-INF/rewrite/java-best-practices.yml b/src/main/resources/META-INF/rewrite/java-best-practices.yml
@@ -38,17 +38,17 @@ name: org.openrewrite.staticanalysis.ReplaceApacheCommonsLang3ValidateNotNullWit
 displayName: Replace `org.apache.commons.lang3.Validate#notNull` with `Objects#requireNonNull`
 description: 'Replace `org.apache.commons.lang3.Validate.notNull(..)` with `Objects.requireNonNull(..)`.'
 recipeList:
-  - org.openrewrite.staticanalysis.ReplaceValidateNotNullHavingSingleArgWithObjectsRequireNonNull
   - org.openrewrite.staticanalysis.ReplaceValidateNotNullHavingVarargsWithObjectsRequireNonNull
+  - org.openrewrite.staticanalysis.ReplaceValidateNotNullHavingSingleArgWithObjectsRequireNonNull
 ---
 type: specs.openrewrite.org/v1beta/recipe
 name: org.openrewrite.staticanalysis.ReplaceValidateNotNullHavingSingleArgWithObjectsRequireNonNull
 displayName: Replace `org.apache.commons.lang3.Validate#notNull` with `Objects#requireNonNull`
 description: 'Replace `org.apache.commons.lang3.Validate.notNull(Object)` with `Objects.requireNonNull(Object)`.'
 recipeList:
   - org.openrewrite.java.ChangeMethodName:
-      methodPattern: org.apache.commons.lang3.Validate notNull(Object)
+      methodPattern: org.apache.commons.lang3.Validate notNull(..)
       newMethodName: requireNonNull
   - org.openrewrite.java.ChangeMethodTargetToStatic:
-      methodPattern: org.apache.commons.lang3.Validate requireNonNull(Object)
+      methodPattern: org.apache.commons.lang3.Validate requireNonNull(..)
       fullyQualifiedTargetTypeName: java.util.Objects
diff --git a/...staticanalysis/ReplaceApacheCommonsLang3ValidateNotNullWithObjectsRequireNonNullTest.java b/...staticanalysis/ReplaceApacheCommonsLang3ValidateNotNullWithObjectsRequireNonNullTest.java
@@ -17,6 +17,7 @@
 
 import org.junit.jupiter.api.Test;
 import org.openrewrite.DocumentExample;
+import org.openrewrite.Issue;
 import org.openrewrite.config.Environment;
 import org.openrewrite.java.JavaParser;
 import org.openrewrite.test.RecipeSpec;
@@ -82,6 +83,34 @@ void test(Object obj) {
         );
     }
 
+    @Issue("https://github.com/openrewrite/rewrite-static-analysis/issues/457")
+    @Test
+    void replaceWithOneArgumentAsString() {
+        rewriteRun(
+          //language=java
+          java(
+            """
+              import org.apache.commons.lang3.Validate;
+
+              class Test {
+                  void test(String obj) {
+                      Validate.notNull(obj);
+                  }
+              }
+              """,
+            """
+              import java.util.Objects;
+
+              class Test {
+                  void test(String obj) {
+                      Objects.requireNonNull(obj);
+                  }
+              }
+              """
+          )
+        );
+    }
+
     @Test
     void replaceMethodsWithTwoArg() {
         rewriteRun(