-
|
I want to write migration that replaces access to field with method call: replace I created TemplateBuilder: private final JavaTemplate callMethodTemplate= JavaTemplate.builder(this::getCursor, "getMvc()")
.build();and invoke it in my JavaVisitor like this: @Override
public J visitIdentifier(J.Identifier ident, ExecutionContext executionContext) {
J.Identifier i = (J.Identifier) super.visitIdentifier(ident, executionContext);
if (i.getFieldType() == null || !"mockMvc".equals(i.getFieldType().getName())) return i;
if (!TypeUtils.isOfClassType(i.getFieldType().getOwner(), "com.example.libs.MockMvcSupport;")) {
return i;
}
return i.withTemplate(callMethodTemplate, i.getCoordinates().replace()); //generates MethodInvocation
}The problem is rewrite test fails with the following error: I understand that in template usage I don't provide return type information, but I don't know how to do for method that is missing at the start of migration. I also can't find any example for doing similar task. Question: How to properly provide type for this case? Just in case, here's the test that I'm running: rewriteRun(
java(
"""
import com.example.libs.MockMvcSupport;
import org.springframework.test.web.servlet.request.MockMvcRequestBuilders;
import org.springframework.test.web.servlet.MockMvc;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.request;
public class BaseAppControllerTest extends MockMvcSupport {
public void sample() {
Object a = this.mockMvc;
}
private void bar() {
MockMvc mockMvc = null;
System.out.println(mockMvc);
}
private void foo(Object o) {}
public void customMethod() throws Exception {
foo(mockMvc);
var asyncResult = result.andExpect(request().asyncStarted())
.andReturn();
result = mockMvc.perform(MockMvcRequestBuilders.asyncDispatch(asyncResult));
}
}
""",
"""
import com.example.libs.MockMvcSupport;
import org.springframework.test.web.servlet.request.MockMvcRequestBuilders;
import org.springframework.test.web.servlet.MockMvc;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.request;
public class BaseAppControllerTest extends MockMvcSupport {
public void sample() {
Object a = this.getMvc();
}
private void bar() {
MockMvc mockMvc = null;
System.out.println(mockMvc);
}
private void foo(Object o) {}
public void customMethod() throws Exception {
foo(getMvc());
var asyncResult = result.andExpect(request().asyncStarted())
.andReturn();
result = getMvc().perform(MockMvcRequestBuilders.asyncDispatch(asyncResult));
}
}
"""
)
) |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 7 replies
-
|
hi @zeldigas ! Could you share with us how you configure the RecipeSpec in your test? That might help fill in some of the blanks with what you're already using or doing to find that What I'm looking for specifically is whether you're using anything like You can see some relevant links to example code in this section of the documentation. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the quick response; in this case I would recommend you use version |
Beta Was this translation helpful? Give feedback.
-
|
Ok, let me try this and get back to you with results |
Beta Was this translation helpful? Give feedback.
-
|
For some reason with stubbing I still get error about problem type Updated template private final JavaTemplate callMethodTemplate = JavaTemplate.builder(this::getCursor, "getMvc()")
.javaParser(JavaParser.fromJavaVersion()
.dependsOn("package com.example.libs;\n" +
"\n" +
"public class MockMvcSupport {\n" +
"\n" +
"protected org.springframework.test.web.servlet.MockMvc getMvc() {\n" +
"return null;\n" +
"}\n" +
"\n" +
"}\n")
.classpath("spring-test")
)
.build();Replacement itself is done correctly, but method fails with error: In debugger I can see that returned value from does not have return type (it is null) |
Beta Was this translation helpful? Give feedback.
-
|
Sounds like we're one step closer; did you already notice that |
Beta Was this translation helpful? Give feedback.
-
|
Yes, it was exactly the reason, thank you! It's was not obvious that I need to add to private final JavaTemplate callMethodTemplate = JavaTemplate.builder(this::getCursor, "getMvc()")
.javaParser(JavaParser.fromJavaVersion()
.dependsOn("package com.example.libs;\n" +
"\n" +
"public class MockMvcSupport {\n" +
"\n" +
"protected org.springframework.test.web.servlet.MockMvc getMvc() {\n" +
"return null;\n" +
"}\n" +
"\n" +
"}\n")
.classpath("spring-test", "test-tools") // <--- without test-tools it will not work
)
.build();Maybe it is possible to improve docs for this? https://docs.openrewrite.org/concepts-explanations/javatemplate#from-stubs |
Beta Was this translation helpful? Give feedback.
-
|
Glad to hear you got things working! I'd have thought adding both That's also why our docs recommend using either |
Beta Was this translation helpful? Give feedback.
Sounds like we're one step closer; did you already notice that
JavaTemplate.builderalso accepts and expects a classpath entry if you're referring to external classes, such as yourMockMvcSupport? Adding that there ought to help resolve the missing type in the recipe as well.