Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

involute_gears.scad has improper pitch check #108

Open
SirNate0 opened this issue Jun 20, 2023 · 0 comments
Open

involute_gears.scad has improper pitch check #108

SirNate0 opened this issue Jun 20, 2023 · 0 comments

Comments

@SirNate0
Copy link

Somehow the check got broken or out of order. The if statement would probably work fine if it were below the ternary operator setting the circular_pitch, or it should check for the diametral_pitch being undef as well.

MCAD/involute_gears.scad

Lines 321 to 325 in bd0a7ba

if (circular_pitch==undef)
echo("MCAD ERROR: gear module needs either a diametral_pitch or circular_pitch");
//Convert diametrial pitch to our native circular pitch
circular_pitch = (circular_pitch!=undef?circular_pitch:pi/diametral_pitch);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant