-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lathe change gears #90
Comments
Integrating those features via new opt-in parameters that sounds like a good approach. Could you submit the PR against the |
the dev branch involute_gears seams quite broken, especially the internal gears. do I fix the involute problems first on a separate branch? I am comfortable with any changes in openscad, but less familiar with this branch/branch/pullrequest github process. |
If it's too much trouble, you can also submit your PR to |
Let me look at the state of the main branch. I will get this in soon, but I am busy at work this week. |
I fixed several issues including fixing the test case, fixing the rack, and adding the spoked gears, all based on the Master. I created a pull request. |
I would like to add a feature for making involute change gears which are used on lathes, which are similar to the gear function in this file, but generally are symmetric about the plane of rotation instead of having the hub offset, and generally have spokes rather than a flat disk or disk with circular holes. I think many will find this useful. I have the code working, and could simply add the features into the existing gear function with the addition of some spoke parameters and a symmetric flag. Otherwise I could have a separate function altogether. I am not sure who is maintaining the involute gear library and want to tread lightly as I go since I am new to this environment. If anyone has advise, please respond.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: