-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GitHub Request] Add @0ctopus13prime as the maintainer for the k-NN repo #257
Labels
Comments
1 task
Pending #258 to be completed before proceeding on this. |
rishabh6788
moved this from ⌛ On Hold
to 🏗 In progress
in Engineering Effectiveness Board
Jan 6, 2025
rishabh6788
moved this from 🏗 In progress
to 📋 Escalation
in Engineering Effectiveness Board
Jan 6, 2025
peterzhuamazon
moved this from 📋 Escalation
to 🏗 In progress
in Engineering Effectiveness Board
Jan 6, 2025
@0ctopus13prime would have received an invite to join the opensearch-project org. Please accept and confirm here. |
@rishabh6788 yes, I received the invitation |
@0ctopus13prime has been added as maintainer for k-NN repo. |
github-project-automation
bot
moved this from 🏗 In progress
to ✅ Done
in Engineering Effectiveness Board
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the type of request?
User Permission
Details of the request
We would like to add @0ctopus13prime to MAINTAINERS.md and .github/CODEOWNERS of opensearch plugin repos [k-NN] so that he can approve PRs and merge code into the main branch.
Additional information to support your request
We have received upvotes (including myself) from existing maintainers of opensearch k-nn to add @0ctopus13prime as the maintainers of this repo.
Doo Yong Kim has been working in k-NN plugin for over 3 months has contributed on some of the core pieces of k-NN plugin and JNI layer. Features includes introducing loading layer for native engines to make k-NN plugin directory agnostic and making k-NN plugin compatible with remote directories for both read and write. He is already working on the Partial graph loading feature for native engines which allow k-NN plugin to run on the memory constraint environment. One of his core expertise includes his experience in C/C++ code and him being a maintainer will allow us to review and optimize the JNI layer further(this can already be seen in his PRs). He has read the contribution guidelines and maintainer responsibilities.
Below are some of his PRs:
opensearch-project/k-NN#2241
opensearch-project/k-NN#2220
opensearch-project/k-NN#2185
opensearch-project/k-NN#2139
opensearch-project/k-NN#1982
opensearch-project/k-NN#1978
opensearch-project/k-NN#1946
opensearch-project/k-NN#1936
Along with the features he has been a review of different pull requests. Some of them are added below.
opensearch-project/k-NN#2320
opensearch-project/k-NN#2308
opensearch-project/k-NN#2345
Tagging maintainers who have already upvoted: @heemin32 @navneet1v @VijayanB @vamshin @naveentatikonda @martin-gaievski @ryanbogan
When does this request need to be completed?
This is not an urgent request. 2-3 business days is fine.
Notes
Track the progress of your request here: https://github.com/orgs/opensearch-project/projects/208/views/33.
Member of @opensearch-project/admin will take a look at the request soon.
Thanks!
The text was updated successfully, but these errors were encountered: