Fix Flaky Test testPendingTasksWithClusterNotRecoveredBlock #17397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]>
kkewwei
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
github-actions
bot
added
>test-failure
cwperks
reviewed
Feb 20, 2025
...internalClusterTest/java/org/opensearch/action/admin/cluster/tasks/PendingTasksBlocksIT.java
Outdated
Show resolved
Hide resolved
|
@kkewwei Thank you for taking a look at this flaky test :) |
cwperks
approved these changes
Feb 20, 2025
|
❌ Gradle check result for bf95318: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Feb 20, 2025
|
❕ Gradle check result for bf95318: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17397 +/- ##
============================================
- Coverage 72.37% 72.35% -0.02%
+ Complexity 65519 65496 -23
============================================
Files 5291 5291
Lines 304302 304325 +23
Branches 44174 44181 +7
============================================
- Hits 220240 220200 -40
- Misses 65997 66018 +21
- Partials 18065 18107 +42 ☔ View full report in Codecov by Sentry. |
|
Thanks @kkewwei! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a situation where the cluster contains 4 nodes, nodeCount=4, dataNodeCount=3
node0(role=cluster_manager)
node1(role=cluster_manager,data)
node2(role=cluster_manager,data)
node3(role=data)
if
gateway.recover_after_data_nodes= 5(nodeCount + 1), when westartDataOnlyNode, dataNodeCount=4, we will never performing state recovery.Related Issues
Resolves #17369
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.