Add support for custom iteration values #696
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Oviedo <[email protected]>
Signed-off-by: Michael Oviedo <[email protected]>
OVI3D0
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
OVI3D0
force-pushed
the
custom-iterations
branch
2 times, most recently
from
e0c6eef
to
e53aef4
Compare
Signed-off-by: Michael Oviedo <[email protected]>
OVI3D0
force-pushed
the
custom-iterations
branch
from
e53aef4
to
460fa64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently, OSB workloads were updated to include parameters for users to input custom iteration values in their test executions. This change gives the new aggregate command the ability to read these values and take them into account when calculating the average values for test executions.
Previously, iterations for each task were stored as a sum of iterations across all test execution. With this change, the iterations for each task are stored separately, so a test with x times the iterations of another will also hold that much more weight in the average calculation.
Also updates the unit tests to reflect the new changes.
Issues Resolved
#670
Testing
make testBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.