Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] setting dashboard annotations on deployment level #843

Open
360build opened this issue Jun 14, 2024 · 4 comments
Open

[FEATURE] setting dashboard annotations on deployment level #843

360build opened this issue Jun 14, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@360build
Copy link

Is your feature request related to a problem?

I like to auto restart my dashboard on secret changes.
To do this annotations I like to have be set on deployment level. Right now it is done on pod level.

What solution would you like?

What alternatives have you considered?

adding some kind extra config options to do this

Do you have any additional context?

https://github.com/opensearch-project/opensearch-k8s-operator/pull/557/files
Support annotations on StatefulSet #557 this issue has solved the same problem for nodes

@360build 360build added enhancement New feature or request untriaged Issues that have not yet been triaged labels Jun 14, 2024
@prudhvigodithi
Copy link
Member

[Triage]
Hey @360build please correct me if i'm wrong, you are referring to have the pod restart once the opensearchCredentialsSecret secret is updated (if so which is already the case) or to restart if the secret value is updated inside admin-credentials-secret ?

  dashboards:
    opensearchCredentialsSecret:
      name: admin-credentials-secret

@swoehrl-mw @salyh @getsaurabh02

@prudhvigodithi prudhvigodithi removed the untriaged Issues that have not yet been triaged label Jun 19, 2024
@360build
Copy link
Author

Hi, thank you for you response

It is indeed correct that on secret change for admin credentials the dashboard will reload by itself.

The only thing is that I have mounted and added some extra secrets. And I want to reload the dashboard when one of these is changing.
I would like to do this with a secret reloaded. This one will require me to set a annotation on the the deployment. But the provider only allows me to set annotations on the pod.

With this no restart get triggered on secret change

@AdaptiveStep
Copy link

AdaptiveStep commented Oct 3, 2024

The certmanager documentation recommends people to use this when syncing various configurations with their workloads:
https://github.com/wave-k8s/wave

I haven't tried out though. But i'm looking for a solution on how to auto-update the secrets / certs as well.

@360build
Copy link
Author

360build commented Nov 4, 2024

That Last one is the same Is I do. But it requires a label on the the deployment not on the pod.
Therefore I need to be able to add label on deployment level :-)
`
If your Pod is reading some ConfigMap or Secret using the API and you want it to be restarted on change you can tell Wave in an annotation:

apiVersion: apps/v1
kind: Deployment
metadata:
annotations:
wave.pusher.com/update-on-config-change: "true"
wave.pusher.com/extra-configmaps: "some-namespace/my-configmap,configmap-in-same-namespace"
wave.pusher.com/extra-secrets: "some-namespace/my-secret,some-other-namespace/foo"
`

Only I am using https://github.com/stakater/Reloader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📦 Backlog
Development

No branches or pull requests

3 participants