Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Matcher.assertThat in sanity tests #3832

Open
DarshitChanpura opened this issue Dec 13, 2023 · 0 comments
Open

Use Matcher.assertThat in sanity tests #3832

DarshitChanpura opened this issue Dec 13, 2023 · 0 comments
Labels
triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@DarshitChanpura
Copy link
Member

Description

The sanity tests framework currently uses inline import for MatcherAssert.assertThat(). When trying to add a static import for the same, the import remains unused as the assertThat() always refers to Junit.assertThat(). This should be looked and fixed.

What is expected?

The tests should have a static import for MatcherAssert.assertThat() and the assertThat() inside tests should refer to this import.
@github-actions github-actions bot added the untriaged Require the attention of the repository maintainers and may need to be prioritized label Dec 13, 2023
@DarshitChanpura DarshitChanpura mentioned this issue Dec 13, 2023
Merged
2 tasks
@peternied peternied added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peternied @DarshitChanpura