Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in releasechecker causing release checks to run smoke instead of full test tags #408

Open
komish opened this issue Dec 2, 2024 · 0 comments

Comments

@komish
Copy link
Contributor

komish commented Dec 2, 2024

When cutting release PRs to production repos, we're seeing this message in the logs that control which set of tests are executed:

PR title indicates PR is not part of a release: 'Workflow and script updates from development repository Release-1.7.5'$'\n'

The bug seems to be here:

if not pr_body.startswith(releaser.CHARTS_PR_BRANCH_BODY_PREFIX):
print(f"PR title indicates PR is not part of a release: {pr_body}")
return False

It would seem that what we're evaluating here doesn't align with what's actually being passed in.

Not a huge issue given that releasing involves running E2E tests before these PRs even get cut to stage/charts repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant