-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Ephemeral namespace perf test #70
base: main
Are you sure you want to change the base?
Fix: Ephemeral namespace perf test #70
Conversation
This patch resolves an issue related to running integration performance tests in the Ephemeral namespace by using the service endpoint instead of the route. This patch also makes setting a secret for the horreum optional.
Hello @markturansky @gurnben , have updated the integration performance test to accommodate the new architectural changes in konflux related to Ephemeral namespace , that is to use the Service endpoint instead of the Application(trex) route as API endpoints for the performance(k6) tests. If you could review the latest patch, that would be great. |
I don't have the necessary knowledge to review this PR, but if it runs and passes automated tests, it's fine with me :) |
Hello @markturansky , I was able to run it successfully in console.dev.redhat.com without issue, below is the log output for reference. `provsion-test1-47d9t-provision-env PROVSION-TEST1-47D9T-PROVISION-ENV [prepare] 2024/11/07 07:45:15 Entrypoint initialization [place-scripts] 2024/11/07 07:45:15 Decoded script /tekton/scripts/script-0-dth28 [request-ephemeral-namespace] + set -o pipefail %!s() provsion-test1-47d9t-extract-secrets PROVSION-TEST1-47D9T-EXTRACT-SECRETS [prepare] 2024/11/07 07:45:14 Entrypoint initialization [place-scripts] 2024/11/07 07:45:15 Decoded script /tekton/scripts/script-0-5jhwr [extract-secrets] Error from server (NotFound): secrets "horreum" not found %!s() provsion-test1-47d9t-deploy-app PROVSION-TEST1-47D9T-DEPLOY-APP [prepare] 2024/11/07 07:45:23 Entrypoint initialization [place-scripts] 2024/11/07 07:45:24 Decoded script /tekton/scripts/script-0-tc55q [unnamed-0] Updating Subscription Management repositories. %!s() provsion-test1-47d9t-perf-benchmark PROVSION-TEST1-47D9T-PERF-BENCHMARK [prepare] 2024/11/07 07:47:39 Entrypoint initialization [place-scripts] 2024/11/07 07:47:39 Decoded script /tekton/scripts/script-0-zpxnp [run-perf] Connecting to github.com (140.82.112.3:443) [check-regression] + horreum_sec_set=false [sidecar-kube-proxy] Forwarding from 127.0.0.1:8080 -> 8000 %!s() provsion-test1-47d9t-cleanup PROVSION-TEST1-47D9T-CLEANUP [prepare] 2024/11/07 07:48:51 Entrypoint initialization [place-scripts] 2024/11/07 07:48:51 Decoded script /tekton/scripts/script-0-l7sl2 [step1] {"result":"SUCCESS","timestamp":"1730965735","failures":0,"successes":0,"warnings":0} %!s() ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and output of passing tests posted to this PR.
This patch resolves an issue related to running integration performance tests in the Ephemeral namespace by using the service endpoint instead of the route. This patch also makes setting a secret for the horreum optional.