Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in user email and comparison config for kube-burner #164

Merged

Conversation

paigerube14
Copy link
Contributor

@paigerube14 paigerube14 commented May 23, 2022

As part of PR we added the ability to get benchmark-comparison google sheet output from kube-burner workloads. Need to add setting of comparison_config, google sheet service account and email to send it to

This only works on jenkins agents that start with "oc4*" for now. Still trying to fix for rhel8 agents

@openshift-ci openshift-ci bot requested review from memodi and rpattath May 23, 2022 21:36
@paigerube14
Copy link
Contributor Author

/assign @qiliRedHat

@qiliRedHat
Copy link
Contributor

@paigerube14
I tested with job https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/scale-ci/job/paige-e2e-multibranch/job/kube-burner-3/56/console

  1. There were some error msgs like
05-24 17:52:05.745  2022-05-24 09:52:05,425 - touchstone - ERROR - Error: Issue capturing results from elasticsearch using config {'filter': {'metricName.keyword': 'podCPU', 'labels.namespace.keyword': 'openshift-ovn-kubernetes'}, 'buckets': ['labels.pod.keyword', 'labels.node.keyword'], 'aggregations': {'value': ['avg']}}
  1. From the result sheet, the last 2 columns data were at wrong places.

OCP Version Flexy Id Scale Ci Job UUID/Grafana URL Status Params Pod Ready Average (ms) Pod Scheduled Avg (ms) Initialized (ms) Containers Ready (ms) Time/Date Snapshot (done manually)

4.11.0-0.nightly-2022-05-18-171831 104086 56 15a42470-aa6b-4f45-863f-3bc171d9156a PASS 1 2405 0 42 2405 https://docs.google.com/spreadsheets/d/1NHU-mD1MqZcZizeJkKvAhpvXVKpKb3ogMEj70qjbhcs *************** 2022-05-24 04:53:58.448785-05:00

@paigerube14
Copy link
Contributor Author

@qiliRedHat those errors need to be fixed upstream I believe. I will run it locally with the same parameters and report back with the results

@paigerube14
Copy link
Contributor Author

If we set the metrics profile to be metrics-profiles/metrics-ovn.yaml it will properly get the missing metrics and runs cleaner

Error message before setting metrics-ovn.yaml file
touchstone - ERROR - Error: Issue capturing results from elasticsearch using config {'filter': {'metricName.keyword': 'podMemory', 'labels.namespace.keyword': 'openshift-sdn'}, 'buckets': ['labels.pod.keyword', 'labels.node.keyword'], 'aggregations': {'value': ['max']}}

Successful run: https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/scale-ci/job/paige-e2e-multibranch/job/kube-burner-3/63/

@qiliRedHat what are your thoughts on setting the default metrics profile to metrics-ovn.yaml for our runs? The 2 files are the exact same except for the addition of podCPU and podMemory metrics are indexed using the ovn yaml file and not the metrics.yaml file

https://github.com/cloud-bulldozer/e2e-benchmarking/blob/4fa5a5ce4856bdc309cba8bab41ed4b68c251c97/workloads/kube-burner/metrics-profiles/metrics-ovn.yaml#L20

@paigerube14
Copy link
Contributor Author

Created PR to not have to specifically set the metrics-ovn.yaml file as the metrics profile so we can properly get the podCPU and podMemory metrics in our google sheet comparison file

@qiliRedHat
Copy link
Contributor

@paigerube14 My run's google sheet is shared to you https://docs.google.com/spreadsheets/d/1NHU-mD1MqZcZizeJkKvAhpvXVKpKb3ogMEj70qjbhcs/edit?usp=sharing.
ContainersReady/Initialized/PodScheduled/Ready's P99 data in podLatency.json are all 0. Are you seeing the same? I asked the access to your run's google sheet.

@paigerube14
Copy link
Contributor Author

@qiliRedHat no I have not seen that. Looks like the data is in elastic search for that run with 0 as the values. I have seen that nothing gets printed to the sheet though. Will have to test more

@paigerube14
Copy link
Contributor Author

@qiliRedHat
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paigerube14, qiliRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [paigerube14,qiliRedHat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e8951af into openshift-qe:kube-burner Jun 2, 2022
@paigerube14 paigerube14 deleted the kube-burner-3 branch October 25, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants