Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating metrics to generate #281

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Updating metrics to generate #281

merged 1 commit into from
Oct 4, 2022

Conversation

paigerube14
Copy link
Contributor

With PR we decided to move to using container CPU and container memory because those metrics were already being captured. So we now need to update the csv generator with that data instead of pods

@paigerube14
Copy link
Contributor Author

/assign @qiliRedHat
/assign @svetsa-rh

jtaleric
jtaleric approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 3, 2022

@jtaleric: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@paigerube14
Copy link
Contributor Author

Properly generating sheet: https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/scale-ci/job/paige-e2e-multibranch/job/kube-burner/92/
NOTE: Failed because of pod metrics timing

@svetsa-rh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jtaleric, paigerube14, svetsa-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c05d60f into openshift-qe:kube-burner Oct 4, 2022
@paigerube14 paigerube14 mentioned this pull request Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtaleric jtaleric jtaleric approved these changes

@mffiedler mffiedler Awaiting requested review from mffiedler

@rpattath rpattath Awaiting requested review from rpattath

Assignees

@qiliRedHat qiliRedHat

@svetsa-rh svetsa-rh

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paigerube14 @svetsa-rh @jtaleric @openshift-merge-robot @qiliRedHat