Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Breakdown workload configmaps into different files #146

Open
rsevilla87 opened this issue Aug 26, 2020 · 0 comments
Open

[RFE] Breakdown workload configmaps into different files #146

rsevilla87 opened this issue Aug 26, 2020 · 0 comments

Comments

@rsevilla87
Copy link
Contributor

The current workload templates has ConfigMaps that embed all logic. This makes difficult to read and contribute to them.
For example this template https://github.com/openshift-scale/workloads/blob/master/workloads/templates/workload-mastervertical-script-cm.yml.j2 embeds run.sh, conprof_start.sh, conprof_stop.sh, workload.sh and all clusterloader templates.

With the current approach there're duplicated code (for example conprof_start.sh is present in other templates).

As an idea to avoid this we could use the command kubectl create cm --from-file=... to create on-fly the ConfigMaps from the scripts required by the workload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant