MGMT-19166: Implement MTU validations for CMN and UMN #7012
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@linoyaslan: This pull request references MGMT-19166 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
do-not-merge/work-in-progress
openshift-ci
bot
added
the
api-review
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: linoyaslan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
linoyaslan
force-pushed
the
MGMT-19166.implement_mtu_validation.linoy
branch
2 times, most recently
from
b37684c to
d0777f3
Compare
linoyaslan
force-pushed
the
MGMT-19166.implement_mtu_validation.linoy
branch
from
d0777f3 to
c3246fd
Compare
openshift-ci
bot
added
size/L
|
/hold |
openshift-ci
bot
added
do-not-merge/hold
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7012 +/- ##
==========================================
+ Coverage 67.81% 68.05% +0.24%
==========================================
Files 289 289
Lines 39608 40054 +446
==========================================
+ Hits 26860 27260 +400
- Misses 10325 10326 +1
- Partials 2423 2468 +45
|
linoyaslan
force-pushed
the
MGMT-19166.implement_mtu_validation.linoy
branch
from
c3246fd to
76cd8f2
Compare
| BeforeEach(func() { | ||
| cluster = hostutil.GenerateTestCluster(clusterID) | ||
| hostId, infraEnvId := strfmt.UUID(uuid.New().String()), strfmt.UUID(uuid.New().String()) | ||
| mockProviderRegistry.EXPECT().IsHostSupported(commontesting.EqPlatformType(models.PlatformTypeVsphere), gomock.Any()).Return(false, nil).AnyTimes() |
There was a problem hiding this comment.
Since the isVSphereDiskUUIDEnabled validation is executed in each unit test (each unit test runs all the validations), we specifically need the mock of IsHostSupported for the vSphere platform -
assisted-service/internal/host/validator.go
Line 1674 in dffaec3
|
@eifrach: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
linoyaslan
force-pushed
the
MGMT-19166.implement_mtu_validation.linoy
branch
from
f7e3c16 to
8f02509
Compare
openshift-merge-robot
added
the
needs-rebase
linoyaslan
force-pushed
the
MGMT-19166.implement_mtu_validation.linoy
branch
2 times, most recently
from
7120e26 to
43d51cf
Compare
openshift-merge-robot
removed
the
needs-rebase
linoyaslan
force-pushed
the
MGMT-19166.implement_mtu_validation.linoy
branch
2 times, most recently
from
286343a to
fd68448
Compare
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
/retest assisted-service-rhel8-mce-downstream-main-on-pull-request |
|
@linoyaslan: The The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
New validations for MTU. There are two separate validations: one for the CMN and another for the UMN. For CMN, we focus on reports from the agent that related specifically to the machine network. For UMN, we consider reports related to all interfaces. You can find the MTU checker added to the agent here - openshift/assisted-installer-agent#821
linoyaslan
force-pushed
the
MGMT-19166.implement_mtu_validation.linoy
branch
from
fd68448 to
435b27f
Compare
|
/lgtm |
|
@linoyaslan: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit be4e1e0
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-agent-installer-api-server |
This PR introduces new validations for MTU. There are two separate validations: one for the CMN and another for the UMN. For CMN, we focus on reports from the agent that related specifically to the machine network. For UMN, we consider reports related to all interfaces. You can find the MTU checker added to the agent here - openshift/assisted-installer-agent#821
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist