package.json dependencies on the provisioning plugin on the branch 4.15 looks to be outdated

[lavocatt]

When I'm checking out the branch 4.15, I'm expecting to find the version 1.0.0 for the dynamic plugin sdk, but I'm seeing 0.0.12

console-plugin-template/package.json

Line 24 in 8376b27

"@openshift-console/dynamic-plugin-sdk": "0.0.12",

What about the other dependencies in the file, are they up-to-date too?

[spadgett]

We should verify that the README is correct and, if so, update the dependency in the 4.15 branch. It would be good to verify the older branches, too.

cc @jhadvig @vojtechszocs

[mikaello]

It seems to be inconsistencies in the other branches as well, e.g release-4.16. The release notes for 4.16 says:

Source: https://docs.openshift.com/container-platform/4.16/release_notes/ocp-4-16-release-notes.html#ocp-4-16-web-console_release-notes

but in package.json react-router 5 is used:

console-plugin-template/package.json

Lines 59 to 60 in d5a16f6

	"react-router": "5.3.x",
	"react-router-dom": "5.3.x",

[spadgett]

@mikaello Thanks for raising this. I believe we still expect to have the older package in the dependencies to give developers time to migrate to v6. It's deprecated, but still there for compatibility. You can use the react-router-dom-v5-compat dependency to begin migrating to v6 if your plugin targets only OpenShift 4.15+.

See https://github.com/openshift/console/blob/master/frontend/packages/console-dynamic-plugin-sdk/README.md#changes-in-shared-modules

@vojtechszocs @jhadvig Can you confirm? I think we should improve the docs around the react-router migration.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[mikaello]

/remove-lifecycle rotten