added yaml lint (#2132)

* added yaml lint

* updated the doc

.golangci.yml

@@ -2,6 +2,9 @@ run:
   timeout: 10m
   skip-dirs:
     - vendor/portal
+    - vendor
+  skip-dirs-use-default: true
+  modules-download-mode: vendor
 
 issues:
   exclude-rules:
@@ -21,7 +24,6 @@ linters-settings:
       - github.com/onsi/ginkgo
       - github.com/onsi/gomega
 
-
 linters:
   disable-all: true
   enable:

.mega-linter.yml

@@ -0,0 +1,14 @@
+# Configuration file for MegaLinter
+# See all available variables at https://megalinter.github.io/configuration/ and in linters documentation
+
+APPLY_FIXES: none
+# ENABLE:  # If you use ENABLE variable, all other languages/formats/tooling formats will be disabled by default
+ENABLE_LINTERS:
+  - YAML_YAMLLINT # If you use ENABLE_LINTERS variable, all other linters will be disabled by default
+EXCLUDED_DIRECTORIES:
+  - vendor
+YAML_YAMLLINT_CONFIG_FILE: .yaml-lint.yml
+LINTER_RULES_PATH: .
+PRINT_ALPACA: false
+GITHUB_STATUS_REPORTER: false
+GITHUB_COMMENT_REPORTER: false

.yaml-lint.yml

@@ -0,0 +1,35 @@
+---
+
+yaml-files:
+  - '*.yaml'
+  - '*.yml'
+  - '.yamllint'
+
+ignore: |
+    vendor/
+    *aro.openshift.io*.yaml
+
+rules:
+  braces: enable
+  brackets: enable
+  colons: enable
+  commas: enable
+  comments: disable
+  comments-indentation: disable
+  document-end: disable
+  document-start: disable
+  empty-lines: enable
+  empty-values: disable
+  hyphens: enable
+  indentation: disable
+  key-duplicates: enable
+  key-ordering: disable
+  line-length: disable
+  new-line-at-end-of-file: enable
+  new-lines: enable
+  octal-values: disable
+  quoted-strings: disable
+  trailing-spaces: enable
+  truthy:
+    level: warning
+    check-keys: false

Makefile

@@ -174,8 +174,7 @@ lint-admin-portal:
 test-python: pyenv az
 	. pyenv/bin/activate && \
 		azdev linter && \
-		azdev style && \
-		hack/format-yaml/format-yaml.py .pipelines
+		azdev style 
 
 admin.kubeconfig:
 	hack/get-admin-kubeconfig.sh /subscriptions/${AZURE_SUBSCRIPTION_ID}/resourceGroups/${RESOURCEGROUP}/providers/Microsoft.RedHatOpenShift/openShiftClusters/${CLUSTER} >admin.kubeconfig