Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e test for pod completion and next pod start #458

Open
tardieu opened this issue Feb 24, 2025 · 2 comments
Open

e2e test for pod completion and next pod start #458

tardieu opened this issue Feb 24, 2025 · 2 comments
Assignees

Comments

@tardieu
Copy link
Contributor

tardieu commented Feb 24, 2025

We test that we do not ungate more pods than we can fit on available gpus by launching 8 long-running 1g pods and checking exactly 7 are running (in a single gpu setup). We should extend such a test to:

  1. confirm that when one of the running pods completes, the pending pod starts running;
  2. verify the transition latency, i.e., that the pending pod starts running without delay.
@harche harche self-assigned this Feb 24, 2025
@asm582
Copy link
Contributor

asm582 commented Feb 24, 2025

Thanks, this test case on KinD does what we ask in 1st sub-bullet point across two GPUs; one pod remains in scheduling gated:

It("should verify all 1g profiles of GPUs are consumed", func() {

@tardieu
Copy link
Contributor Author

tardieu commented Feb 24, 2025

AFAIK this test only addresses point 0, i.e., one pod remains gated, not point 1, i.e., the gated pod eventually runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants