Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyperdisk-extreme disk type #1271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

damdo
Copy link
Member

@damdo damdo commented Aug 2, 2024

Following up on the work of #1268 which introduced hyperdisk-balanced support, this PR introduces support for hyperdisk-extreme.

  • Add the hyperdisk-extreme disk type for gcp machines.
  • Add the test to validate the new type.

@openshift-ci openshift-ci bot requested review from elmiko and nrb August 2, 2024 13:32
Copy link
Contributor

openshift-ci bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from damdo. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danilo-gemoli
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2024
@damdo
Copy link
Member Author

damdo commented Aug 2, 2024

/hold

For manual testing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2024
Copy link
Contributor

openshift-ci bot commented Aug 2, 2024

@damdo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack f8d6936 link false /test e2e-openstack
ci/prow/e2e-metal-ipi f8d6936 link false /test e2e-metal-ipi
ci/prow/e2e-metal-ipi-virtualmedia f8d6936 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-vsphere-ovn f8d6936 link false /test e2e-vsphere-ovn
ci/prow/e2e-vsphere-ovn-serial f8d6936 link false /test e2e-vsphere-ovn-serial
ci/prow/e2e-metal-ipi-ovn-dualstack f8d6936 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-vsphere-ovn-upgrade f8d6936 link false /test e2e-vsphere-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 1, 2024
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants