Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-1800: Add support for vSphere host and vm group based zonal #1285

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

SPLAT-1800: Add support for vSphere host and vm group based zonal #1285

wants to merge 1 commit into from

Conversation

jcpowermac
Copy link
Contributor

@jcpowermac jcpowermac commented Sep 9, 2024 •
edited
Loading

Changes

Implements the new workspace field vmGroup to:

  • adds or remove the MAO deployed virtual machine in the list of virtual machines within the vcenter cluster's vm-host group of type virtual machine.

Additional PRs

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2024
@jcpowermac jcpowermac changed the title Hostvmgroupzones Add support for vSphere host and vm group based zonal Sep 9, 2024
@jcpowermac
Copy link
Contributor Author

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

@jcpowermac: The following commands are available to trigger required jobs:

  • /test e2e-aws-operator
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-upgrade
  • /test goimports
  • /test golint
  • /test govet
  • /test images
  • /test unit
  • /test verify-crds-sync
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test e2e-azure-manual-oidc
  • /test e2e-azure-operator
  • /test e2e-azure-ovn
  • /test e2e-gcp-operator
  • /test e2e-gcp-ovn
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-upgrade
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-nutanix
  • /test e2e-openstack
  • /test e2e-vsphere-operator
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-ovn-serial
  • /test e2e-vsphere-ovn-upgrade
  • /test e2e-vsphere-static-ovn
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-machine-api-operator-master-e2e-aws-operator
  • pull-ci-openshift-machine-api-operator-master-e2e-aws-ovn
  • pull-ci-openshift-machine-api-operator-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-machine-api-operator-master-e2e-azure-operator
  • pull-ci-openshift-machine-api-operator-master-e2e-azure-ovn
  • pull-ci-openshift-machine-api-operator-master-e2e-gcp-operator
  • pull-ci-openshift-machine-api-operator-master-e2e-gcp-ovn
  • pull-ci-openshift-machine-api-operator-master-e2e-metal-ipi
  • pull-ci-openshift-machine-api-operator-master-e2e-metal-ipi-ovn-dualstack
  • pull-ci-openshift-machine-api-operator-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-machine-api-operator-master-e2e-metal-ipi-upgrade
  • pull-ci-openshift-machine-api-operator-master-e2e-metal-ipi-virtualmedia
  • pull-ci-openshift-machine-api-operator-master-e2e-nutanix
  • pull-ci-openshift-machine-api-operator-master-e2e-openstack
  • pull-ci-openshift-machine-api-operator-master-e2e-vsphere-operator
  • pull-ci-openshift-machine-api-operator-master-e2e-vsphere-ovn
  • pull-ci-openshift-machine-api-operator-master-e2e-vsphere-ovn-serial
  • pull-ci-openshift-machine-api-operator-master-e2e-vsphere-ovn-upgrade
  • pull-ci-openshift-machine-api-operator-master-goimports
  • pull-ci-openshift-machine-api-operator-master-golint
  • pull-ci-openshift-machine-api-operator-master-govet
  • pull-ci-openshift-machine-api-operator-master-images
  • pull-ci-openshift-machine-api-operator-master-unit
  • pull-ci-openshift-machine-api-operator-master-verify-crds-sync
  • pull-ci-openshift-machine-api-operator-master-yaml-lint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcpowermac
Copy link
Contributor Author

/test goimports
/test golint
/test govet
/test images
/test unit
/test verify-crds-sync
/test yaml-lint

@jcpowermac
Copy link
Contributor Author

/test goimports
/test golint
/test govet
/test images
/test unit
/test verify-crds-sync
/test yaml-lint

@jcpowermac jcpowermac force-pushed the hostvmgroupzones branch 2 times, most recently from d098ada to 188cb86 Compare September 11, 2024 12:58
@jcpowermac jcpowermac changed the title Add support for vSphere host and vm group based zonal SPLAT-1800: Add support for vSphere host and vm group based zonal Sep 12, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 12, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 12, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1800 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac jcpowermac force-pushed the hostvmgroupzones branch 2 times, most recently from 1ae6b9b to b856851 Compare September 16, 2024 18:21
This was referenced Sep 23, 2024
Merged
Open
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2024
@jcpowermac jcpowermac force-pushed the hostvmgroupzones branch 3 times, most recently from bf7b850 to 4a4d0f3 Compare October 2, 2024 13:18
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign theobarberbany for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This was referenced Oct 22, 2024
Merged
Draft
@jcpowermac jcpowermac force-pushed the hostvmgroupzones branch 2 times, most recently from 967611f to 5b2b4a5 Compare October 24, 2024 17:24
@jcpowermac
Copy link
Contributor Author

/test goimports
/test golint
/test govet
/test images
/test unit
/test verify-crds-sync
/test yaml-lint

@jcpowermac jcpowermac force-pushed the hostvmgroupzones branch 2 times, most recently from 223ccb6 to 9f0bb7a Compare October 31, 2024 14:20
@jcpowermac jcpowermac mentioned this pull request Nov 13, 2024
Draft
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1800 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Changes

Implements the new workspace field vmGroup to:

  • adds or remove the MAO deployed virtual machine in the list of virtual machines within the vcenter cluster's vm-host group of type virtual machine.

Additional PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Contributor Author

/test goimports
/test golint
/test govet
/test images
/test unit
/test verify-crds-sync
/test yaml-lint

@vr4manta
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Nov 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

New changes are detected. LGTM label has been removed.

@jcpowermac
Copy link
Contributor Author

/test goimports
/test golint
/test govet
/test images
/test unit
/test verify-crds-sync
/test yaml-lint

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2024
@jcpowermac
Support host and vm group based zonal
e85ba3c 
This commit adds a new function: `moveToVMGroup`
that modifies the vSphere Cluster vm group to add
a machine api operator created virtual machine to the list.
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2024
@jcpowermac
Copy link
Contributor Author

/test goimports
/test golint
/test govet
/test images
/test unit
/test verify-crds-sync
/test yaml-lint

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@jcpowermac: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit e85ba3c link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vr4manta vr4manta

Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcpowermac @openshift-ci-robot @vr4manta @openshift-merge-robot