-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s2i : add extra steps to get s2i image builder labels #3
Comments
It might be more relevant for the generic s2i task in tektoncd/catalog? Given that in runtime-specific tasks we know which builder image is building used and can pass the correct params to |
ohh good point, we definitely need that on the upstream catalog too, let me create an issue there too |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Related to openshift/source-to-image#973,
s2i build --as-dockerfile
doesn't read those labels, and thus some s2i can later failed if the runtime script are not at the default places.As a temporary workaround, we should add a
skopeo
inspect step that gets those labels, so that we can specify the correct flags tos2i build --as-dockerfile
👼cc @piyush-garg @siamaksade
The text was updated successfully, but these errors were encountered: