This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

Move Deployments interfaces out of deployments.service.ts #2962

Closed

2 tasks done

andrewazores opened this issue Apr 9, 2018 · 0 comments

Closed

2 tasks done

Move Deployments interfaces out of deployments.service.ts #2962

andrewazores opened this issue Apr 9, 2018 · 0 comments

Assignees

Labels

area/deployments team/platform train/heather type/task

Milestone

Collaborator

andrewazores commented Apr 9, 2018 •

edited

Loading

Parent: #2921

Task

Currently, many of the types (interfaces) used by the Deployments page to represent various data and WIT API response formats are contained in and exported by the deployments.service.ts file. The DeploymentsService class itself is being repositioned so that it is internal to the Deployments page, with the intended service for external consumers being the DeploymentApiService. For this reason, all of the interfaces contained in deployments.service.ts that are not Deployments-specific and are relevant for any consumer of the DeploymentApiService should be moved, either into deployment-api.service.ts or the deployments/models directory.

Relationships

Provide DeploymentApiService #2924 Provide DeploymentApiService
Refactor DeploymentsService to use DeploymentApiService #2925 Refactor DeploymentsService to use DeploymentApiService

andrewazores added type/task team/platform area/deployments train/heather labels

andrewazores added this to the Platform Backlog milestone

andrewazores mentioned this issue

[8] Refactor UI DeploymentsService for external consumers #2921

Closed

4 tasks

andrewazores self-assigned this

andrewazores modified the milestones: Platform Backlog, Sprint 148

andrewazores added a commit to andrewazores/fabric8-ui that referenced this issue


          refactor(deployments): move interfaces out of deployments.service.ts

99b5e61

Interfaces used to define the shape of Deployments backend API responses are moved to
deployment-api.service.ts so that they are next to the functions that return them. Two unused
interfaces (Environment and Pods) are removed entirely. NetworkStat is moved to models to fit with
CpuStat and MemoryStat.

related to openshiftio/openshift.io#2962

andrewazores added a commit to andrewazores/fabric8-ui that referenced this issue


          refactor(deployments): add ScaledStat interface

d71b30e

Add a ScaledStat interface to provide a common type for ScaledNetworkStat and ScaledMemoryStat

fixes openshiftio/openshift.io#2962

andrewazores added a commit to andrewazores/fabric8-ui that referenced this issue


          refactor(deployments): move interfaces out of deployments.service.ts

e45b1d6

Interfaces used to define the shape of Deployments backend API responses are moved to
deployment-api.service.ts so that they are next to the functions that return them. Two unused
interfaces (Environment and Pods) are removed entirely. NetworkStat is moved to models to fit with
CpuStat and MemoryStat.

related to openshiftio/openshift.io#2962

andrewazores added a commit to andrewazores/fabric8-ui that referenced this issue


          refactor(deployments): add ScaledStat interface

c54cb6a

Add a ScaledStat interface to provide a common type for ScaledNetworkStat and ScaledMemoryStat

fixes openshiftio/openshift.io#2962

andrewazores added a commit to fabric8-ui/fabric8-ui that referenced this issue


          refactor(deployments): move interfaces out of deployments.service.ts

3683fb7

Interfaces used to define the shape of Deployments backend API responses are moved to
deployment-api.service.ts so that they are next to the functions that return them. Two unused
interfaces (Environment and Pods) are removed entirely. NetworkStat is moved to models to fit with
CpuStat and MemoryStat.

related to openshiftio/openshift.io#2962

andrewazores closed this as completed in


      fabric8-ui/fabric8-ui@13128a4

sanketpathak pushed a commit to sanketpathak/fabric8-ui that referenced this issue


          refactor(deployments): move interfaces out of deployments.service.ts

f7f639b

Interfaces used to define the shape of Deployments backend API responses are moved to
deployment-api.service.ts so that they are next to the functions that return them. Two unused
interfaces (Environment and Pods) are removed entirely. NetworkStat is moved to models to fit with
CpuStat and MemoryStat.

related to openshiftio/openshift.io#2962

sanketpathak pushed a commit to sanketpathak/fabric8-ui that referenced this issue


          refactor(deployments): add ScaledStat interface

08c5fae

Add a ScaledStat interface to provide a common type for ScaledNetworkStat and ScaledMemoryStat

fixes openshiftio/openshift.io#2962

sanketpathak pushed a commit to sanketpathak/fabric8-ui that referenced this issue


          refactor(deployments): move interfaces out of deployments.service.ts

81abcd1

Interfaces used to define the shape of Deployments backend API responses are moved to
deployment-api.service.ts so that they are next to the functions that return them. Two unused
interfaces (Environment and Pods) are removed entirely. NetworkStat is moved to models to fit with
CpuStat and MemoryStat.

related to openshiftio/openshift.io#2962

sanketpathak pushed a commit to sanketpathak/fabric8-ui that referenced this issue


          refactor(deployments): add ScaledStat interface

4d2fd91

Add a ScaledStat interface to provide a common type for ScaledNetworkStat and ScaledMemoryStat

fixes openshiftio/openshift.io#2962

sanketpathak pushed a commit to sanketpathak/fabric8-ui that referenced this issue


          refactor(deployments): move interfaces out of deployments.service.ts

2d6bf6d

Interfaces used to define the shape of Deployments backend API responses are moved to
deployment-api.service.ts so that they are next to the functions that return them. Two unused
interfaces (Environment and Pods) are removed entirely. NetworkStat is moved to models to fit with
CpuStat and MemoryStat.

related to openshiftio/openshift.io#2962

sanketpathak pushed a commit to sanketpathak/fabric8-ui that referenced this issue


          refactor(deployments): add ScaledStat interface

43a1eb3

Add a ScaledStat interface to provide a common type for ScaledNetworkStat and ScaledMemoryStat

fixes openshiftio/openshift.io#2962

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.