Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider shipping an openslide-bin Python package #160

Closed
bgilbert opened this issue Oct 27, 2023 · 1 comment · Fixed by #232
Closed

Consider shipping an openslide-bin Python package #160

bgilbert opened this issue Oct 27, 2023 · 1 comment · Fixed by #232

Comments

@bgilbert
Copy link
Member

Once we have self-contained shared libraries for all three major platforms, it might make sense to ship a Python package that just provides those binaries, as a convenience. That would make the OpenSlide Python stack entirely pip-installable.

OpenSlide Python could preferentially use openslide-bin if present, and provide a pointer to it if OpenSlide can't be found. Downstream packagers could ignore the new package entirely.

Releases of the new package would be tied to releases in this repo rather than to OpenSlide Python, so I think it makes sense to keep the packaging glue in this repo.

@bgilbert
Copy link
Member Author

bgilbert commented Nov 1, 2023

Registered openslide-bin in PyPI.

bgilbert added a commit to bgilbert/openslide-bin that referenced this issue Nov 15, 2023
Needed for Python wheel support.  auditwheel is Linux-specific, and tomli
is already included in the Windows builder container.  Neither is
available via dnf.  (tomli is, but not for Python 3.8.)

For: openslide#160
Signed-off-by: Benjamin Gilbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant