Skip to content

Commit

Permalink
workflows: add CPU architecture to names of workflow artifacts
Browse files Browse the repository at this point in the history
We'll need to ensure uniqueness of Linux artifact names once we're also
building for aarch64, so make the change on all OSes for consistency.  The
change doesn't affect the filenames inside the artifacts, so shouldn't be
user-visible.

Signed-off-by: Benjamin Gilbert <[email protected]>
  • Loading branch information
bgilbert committed Sep 9, 2024
1 parent 6d469ff commit ef4b189
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,11 @@ jobs:
run: |
case "${{ matrix.os }}" in
ubuntu-latest)
echo OS_TAG=linux >> $GITHUB_ENV
echo OS_ARCH_TAG=linux-x86_64 >> $GITHUB_ENV
sudo apt-get install libopenslide0
;;
macos-latest)
echo OS_TAG=macos >> $GITHUB_ENV
echo OS_ARCH_TAG=macos-arm64-x86_64 >> $GITHUB_ENV
echo DYLD_LIBRARY_PATH=/opt/homebrew/lib >> $GITHUB_ENV
brew install openslide
;;
Expand Down Expand Up @@ -151,7 +151,7 @@ jobs:
if: env.archive_wheel
uses: actions/upload-artifact@v4
with:
name: ${{ needs.pre-commit.outputs.dist-base }}-${{ env.OS_TAG }}-${{ matrix.python-version }}
name: ${{ needs.pre-commit.outputs.dist-base }}-${{ env.OS_ARCH_TAG }}-${{ matrix.python-version }}
path: artifacts/whl
compression-level: 0

Expand Down Expand Up @@ -223,7 +223,7 @@ jobs:
if: env.archive_wheel
uses: actions/upload-artifact@v4
with:
name: ${{ needs.pre-commit.outputs.dist-base }}-windows-${{ matrix.python-version }}
name: ${{ needs.pre-commit.outputs.dist-base }}-windows-x64-${{ matrix.python-version }}
path: artifacts/whl
compression-level: 0

Expand Down

0 comments on commit ef4b189

Please sign in to comment.