-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decimals in the firmware versions do not always display properly #30
Comments
Try entering the numbers as 1.1 and 1.3 (or 1.001 and 1.003). In theory it shouldn't matter - the two sides of the decimal should be treated separately, so 1.1 should be the same as 1.01 or 1.001, but maybe there's an issue with the way this conversion is done as we'd normally present this as 1.003 or 1.3 |
Hmmm. I have not yet updated the firmware and I'm relying on Zooz and the documentation for the version number. I'll get it updated and see what version it actually shows up as. |
In ZWave, as many other versioning systems, the two numbers are treated as a minor and major version and not as a single decimal value. |
I updated the firmware. The device was not recognized, so I updated the database entry again. I entered the min as 1.001 and max as 1.003 and it is displayed as... .. and... Entering as 1.1 and 1.3, or 1.100 and 1.300, resulted in an error... This is not intuitive. If anything, we should have a note that the minor version must be entered as a three digit number. It seems the number is being padded from the right (3 becomes 300), so maybe this could be changed to pad from the left (3 becomes 003). Either way, the display seems to be removing all of the zeros to the left (1.030 shows as 1.30, see above). Feature request for the future... there also seems to be no way to cancel changes. I just went in to get the screenshots and had to approve the changes rather than remove them. Best wishes in the new year! |
Clearly this is a bug so we shouldn't document this (IMHO). I will try and take a look at it. FTR - 1.3 should be the same as 1.003, and different from 1.030 (which is the same as 1.30 - major rev 1, and minor rev 30). Regarding cancelling changes - this would be a major change to the database to find some way to revert any changes that had been made across the dozen or so tables that make up a devices definition. I do agree - this would really be super helpful, but I'm not sure that it's worth it for the few times it's needed as it would really be a lot of work I think. |
Happy New Year and welcome to independence, Chris 🤣 |
Thanks - and to you all as well.
Yeah - well, don't get me started on that ;)
Yes, version numbers are 1 byte - so 0 to 255, or 0.0 to 255.255. Sometimes you might see 255.255 written somewhere as this is used internally and gets converted to
I did set your account back up, but probably didn't send you the password. In theory, I believe that you should have got an email from the system (since I ticked a box to initialise by email - or something like that) but I guess you didn't receive it? I forget when I did that - sometime in the past week. |
I never got the email but, IIRC that was just for the database access, correct? |
No - it's not just the database access - it's the complete website. It is possible to edit stuff there without Wappler (that is what I am also doing). If we have multiple people doing that though, we will just need to be careful. More complex parts may be difficult to edit without Wappler, and Wappler definitely makes things easier, but most stuff is possible without it (unless we wanted to make major changes, or add a new page etc - that could be done, but really would be best to use the editor). |
OK, I will wait for the email. If you wish, I can send you my old password. I will just need to wrap my head around the directory structure. Do you edit in the browser or is there something like git access? |
I guess the mail won’t come now if it hasn’t in the past week :)
I will take a look later and see if there’s an option to resent, otherwise I’ll set a password and send you a mail.
|
Please let me know if this is now working as you expect. |
Getting there!
While on the subject of firmware versions, as a noob looking in, it is not clear whether the min and max are inclusive. Currently, 1.0-1.3 means that the firmware is >1.0 and <=1.3. At least, that is how I understand it! When I see 1.0-1.3, I take it to mean that 1.0 is also included. Using set notation, a left-open and right-closed interval might be more descriptive, (1.0, 1.3], but you may need to be familiar with set theory. |
The newest version of the firmware for the ZEN16 is 1.03.
I entered the lower bound as 1.01 and upper as 1.03. This displays as 1.10-1.30.
The text was updated successfully, but these errors were encountered: