Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update parse_npm_git_url macro for improved URL parsing #2525

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

Jabolol
Copy link
Contributor

@Jabolol Jabolol commented Nov 26, 2024

This PR addresses edge cases found when extracting information from npm Git URLs to ensure consistency.

  • Git URLs that include a #revision at the end.
  • Git URLs containing /blob/... or /tree/... instead of the absolute URL.
  • Git URLs that omit the .git suffix.

These cases have been handled to standardize URL processing across the board.

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kariba-network ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 8:00pm
oso-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 8:00pm

Copy link

@oso-prs oso-prs bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved! please merge responsibly 😄

@oso-prs
Copy link

oso-prs bot commented Nov 26, 2024

Test deployment for PR #2525 successfully deployed to oso-pull-requests.pr_2525.

@Jabolol Jabolol added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 22a47b2 Nov 26, 2024
9 checks passed
@Jabolol Jabolol deleted the jabolol/parse-npm-url-fix branch November 26, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant