Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing elements in 3d model #1100

Closed
JanoSlivka opened this issue Jan 21, 2020 · 7 comments
Closed

Missing elements in 3d model #1100

JanoSlivka opened this issue Jan 21, 2020 · 7 comments

Comments

@JanoSlivka
Copy link

Hello,

I can show ifc file tzb_ifc4.zip with bim surfer 3 and bim server 1.5.172. In 3d model missing few elements, show images:

BimSurfer3
tzb_surfer3
Solibri
tzb_solibri

Thanks for help

@rubendel
Copy link
Member

About 79 objects in this file are causing errors in IfcOpenShell (which can be seen in the geometry generation report). I don't think this is a viewer problem, moving to BIMserver repository.

@rubendel rubendel transferred this issue from opensourceBIM/BIMsurfer Jan 30, 2020
@hlg
Copy link
Member

hlg commented Mar 1, 2021

This issue will be resolved with the next plugin version for IfcOpenShell: opensourceBIM/IfcOpenShell-BIMserver-plugin@732da23. As an immediate workaround, the engine version can be changed in a running BIMserver instance through the IfcOpenShell plugin's settings. The setting Commit Sha would have to be changed to "3bbdc3f".

@JanoSlivka
Copy link
Author

This issue is not solved by IfcOpenShell plugin's "3bbdc3f". Elements are still missing.

@hlg
Copy link
Member

hlg commented May 26, 2021

Yes, you are right, even with the very latest IfcOpenShell version (commit SHA 81ad689), there are about 28 entities failing. This seems only partially solved.

@zaqifathis
Copy link
Collaborator

zaqifathis commented Aug 22, 2024

Tested with the latest IfcOpenShell-BIMserver plugin (commit 179e960). Total about 28 elements/entities (IfcDuctFitting, IfcDuctSegment, IfcPipeFitting) are still missing.

image

and I get this error message from Geometry generation report:

java.lang.Exception: Missing objects in model (...)
	at org.bimserver.geometry.GeometryRunner.run(GeometryRunner.java:833)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)

@hlg
Copy link
Member

hlg commented Aug 22, 2024

The exception "Missing objects in model" means that IfcOpenShell was not able to generate geometry for these entities (see BIMserver IfcOpenShell plugin read.me. I went through all of the failing entities' geometries and found that they are faulty in two categories.

  1. All the IfcPipeFitting and IfcDuctSegment entities as well as half of the IfcDuctFitting entities have geometry of type IfcExtrudedAreaSolid, IfcExtrudedAreaSolidTapered or IfcRevolvedAreaSolid and profiles of type IfcCircleHollowProfileDef where the WallThickness is 0. This is invalid geometry because WallThickness should be of type IfcPositiveLengthMeasure, hence greater than zero.
  2. The remaining IfcDuctFitting entities have geometry of type IfcExtrudedAreaSolid where the Depth is 0. This is invalid as well for the same reason (must be of type IfcPositiveLengthMeasure, hence greater than zero).

Apparently, other software such as Solibri accepts (at least some of) the invalid geometries although this might lead to downstream issues. The errors of the second type would not make a visible difference, no matter whether other software accepts these faulty entities.

I would suggest to close this as I do not expect IfcOpenShell to change the behaviour in this regard. On the contrary, with a thorough schema validation, such files could even be rejected upon checkin.

@hlg
Copy link
Member

hlg commented Sep 16, 2024

There is a new issue to include this particular IfcOpenShell setting in the render engine configuration potentially: opensourceBIM/IfcOpenShell-BIMserver-plugin#17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants