Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for shared secrets to mkem_kex() #1112

Open
Sashan opened this issue Feb 21, 2025 · 0 comments
Open

add test for shared secrets to mkem_kex() #1112

Sashan opened this issue Feb 21, 2025 · 0 comments

Comments

@Sashan
Copy link

Sashan commented Feb 21, 2025

There is a TODO note in fuzz/ml-kem.c, it reads as follows:

405 static void mlkem_kex(uint8_t **buf, size_t *len, void *key1, void *key2,
406                       void **out1, void **out2)
407 {
408     EVP_PKEY *alice = (EVP_PKEY *)key1;
409     EVP_PKEY *bob = (EVP_PKEY *)key2;
410     size_t boblen, alicelen;
411     uint8_t *bobshare = NULL;
412     uint8_t *aliceshare = NULL;
413
414     do_derive(alice, bob, &aliceshare, &alicelen);
415     do_derive(bob, alice, &bobshare, &boblen);
416
417     /*
418      * TODO add check of shared secrets here when ML-KEM supports this
419      */
420     OPENSSL_free(bobshare);
421     OPENSSL_free(aliceshare);
422 }

I'm just filing the ticket to remember

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Pre-Refinement
Development

No branches or pull requests

1 participant