Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launchpad charm build fails because of invalid charmcraft.yaml configuration #28

Open
jadonn opened this issue Aug 9, 2023 · 2 comments
Open

Launchpad charm build fails because of invalid charmcraft.yaml configuration #28

jadonn opened this issue Aug 9, 2023 · 2 comments

Comments

@jadonn
Copy link
Contributor

jadonn commented Aug 9, 2023 •
edited
Loading

There were some Launchpad failures this week because charmcraft reported the field reactive-charm-build-arguments was not permitted in parts.charm configuration for reactive charms. Here is an example of the mysql-innodb-cluster charm master branch build failing for this reason:

https://launchpad.net/~openstack-charmers/charm-mysql-innodb-cluster/+charm/charm-mysql-innodb-cluster.master.latest/+build/11276

The relevant error message is:

2023-08-09 03:51:11.079 Bad charmcraft.yaml content: - extra field 'reactive-charm-build-arguments' not permitted in 'parts.charm' configuration

The agreed upon resolution in the August 9th, 2023 weekly IRC #openstack-charms meeting was to update lp-builder-config definitions for master branches to charmcraft 2.x/stable. Edit: I forgot to mention that the mysql-innodb-cluster was using charmcraft 1.7/stable for this build.

@wolsen manually confirmed in Launchpad that changing the recipe to use 2.x/stable resolves the issue for the mysql-innodb-cluster.

I'm going to get a PR submitted that makes this change for the master branch in the mysql-innodb-cluster charm and the other charms in misc.yaml.
jadonn added a commit to jadonn/charmed-openstack-info that referenced this issue Aug 9, 2023
@jadonn
Launchpad charm build fails because of invalid charmcraft.yaml config
dd3dc20 
This fix moves the charm build recipes to use charmcraft 2.x/stable
instead of older versions of charmcraft.
We are experiencing build failures because charmcraft thinks
otherwise valid charmcraft.yaml configuration is invalid.

Closes: Issue openstack-charmers#28
@jadonn jadonn mentioned this issue Aug 9, 2023
Merged
@jadonn
Copy link
Contributor Author

jadonn commented Aug 9, 2023

I submitted a PR on this issue. Should I do the other charms like in ovn.yaml or ceph.yaml?

@jadonn
Copy link
Contributor Author

jadonn commented Aug 10, 2023

I'm going to submit a PR with this change for ovn.yaml and ceph.yaml as well.

jadonn added a commit to jadonn/charmed-openstack-info that referenced this issue Aug 10, 2023
@jadonn
Launchpad charm build fails because of invalid charmcraft.yaml config
6734c1d 
This fix moves the charm build recipes to use charmcraft 2.x/stable
instead of older versions of charmcraft.
We are experiencing build failures because charmcraft thinks
otherwise valid charmcraft.yaml configuration is invalid.

Closes: Issue openstack-charmers#28
jadonn added a commit to jadonn/charmed-openstack-info that referenced this issue Aug 10, 2023
@jadonn
Launchpad charm build fails because of invalid charmcraft.yaml config
a205563 
This fix moves the charm build recipes to use charmcraft 2.x/stable
instead of older versions of charmcraft.
We are experiencing build failures because charmcraft thinks
otherwise valid charmcraft.yaml configuration is invalid.

Closes: Issue openstack-charmers#28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jadonn