Add retry decorator for download_image function #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajkavanagh
requested changes
Jun 30, 2022
There was a problem hiding this comment.
Thanks very much for your patch. There are however, a couple of problems.
One minor comment on the actual change; however, the multiple formatting changes obscure the change and should not be part of the PR please. Also, they cause a PEP8 failure as many of them are not compatible with the PEP8 options for the project. Please use tox -e pep8 and tox -e py3 to verify your changes prior to submission. Thanks.
Comment on lines
+2306
to
+2316
| DNS_ISSUES = [ | ||
| EAI_AGAIN, | ||
| EAI_BADFLAGS, | ||
| EAI_FAIL, | ||
| EAI_FAMILY, | ||
| EAI_MEMORY, | ||
| EAI_NODATA, | ||
| EAI_NONAME, | ||
| EAI_SERVICE, | ||
| EAI_SOCKTYPE | ||
| ] |
There was a problem hiding this comment.
You could use a tuple here, rather than a list, to make it immutable as it should not change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues/PR
Fix Issue #775.
Changes