Add job to run kuttl without install_yamls #2571

cescgina · 2024-11-26T12:11:48Z

This change attempts to make the approach that nova-operator uses to run
kuttl more generic, so it can be used in other operators that follow
a similar patter in their tests, like watcher-operator.

Related: OSPRH-11424

openshift-ci · 2024-11-26T12:11:53Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2024-11-26T12:11:56Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cescgina. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

zuul.d/kuttl_multinode.yaml

softwarefactory-project-zuul · 2024-11-27T21:01:47Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8cb680713d79422991d1aa87aaac0caa

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 42m 00s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 32s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 28m 50s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 50s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 52s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 00s
❌ cifmw-multinode-kuttl TIMED_OUT in 2h 39m 08s
✔️ build-push-container-cifmw-client SUCCESS in 21m 51s

In the depends-on PR, a new job definition is introduced that runs kuttl tests following the pattern used in nova-operator. This is done mainly to reuse the job definition for watcher-operator, which has just introduced kuttl testing following the same pattern. This change modifies the nova job to use the same parent. Depends-On: openstack-k8s-operators/ci-framework#2571

cescgina · 2024-11-28T14:13:04Z

tested the job definition by changing the nova-operator kuttl job to use it in openstack-k8s-operators/nova-operator#902 , job is passing openstack-k8s-operators/nova-operator#902 (comment)

cescgina · 2024-11-28T16:04:58Z

also got a green run from the watcher-operator version https://softwarefactory-project.io/zuul/t/rdoproject.org/build/6ed0fe8ce7ed433ca20ec7bbd71e9095 via openstack-k8s-operators/watcher-operator#14

This job uses a parent job defined in [1] based on the existing nova-operator. [1] openstack-k8s-operators/ci-framework#2571

pablintino · 2024-11-28T16:40:06Z

ci/playbooks/kuttl/deploy-deps.yaml

+            KUBECONFIG: "{{ cifmw_openshift_kubeconfig }}"
+            PATH: "{{ cifmw_path | default(ansible_env.PATH) }}"


Why not passing this environment vars as part of the block to avoid repeating the same thing 4 times?

good catch, done

pablintino · 2024-11-28T16:46:01Z

ci/playbooks/kuttl/deploy-deps.yaml

+    - name: Check we have some compute in inventory
+      ansible.builtin.set_fact:
+        has_compute: >-
+          {% set ns = namespace(found=false) -%}


No need to use a namespace, a regular var is enough. Moreover, this can be done without jinja2 scripts with plain ansible-jinja2 filters:

hostvars.keys() | select('search', '^compute.*') | length > 0

actually we don't set a compute in the nodeset for this job. I carried this from the nova kuttl job, but it must be there for a different reason, since the kuttl nodeset does not have compute nodes. I'm removing this task

pablintino · 2024-11-28T16:47:26Z

ci/playbooks/kuttl/deploy-deps.yaml

+    - name: Assert that operator_name is set
+      ansible.builtin.assert:
+        that:
+          - operator_name is defined


If we move this to line 8 we can safe some time/resources/bandwith if the assertion is not met.

done, thanks

pablintino · 2024-11-28T16:48:23Z

ci/playbooks/kuttl/deploy-deps.yaml

+  ansible.builtin.import_playbook: "../../../playbooks/01-bootstrap.yml"
+
+- hosts: "{{ cifmw_target_host | default('localhost') }}"
+  name: install dev tools


An un-capitalized playbook name looks strange.

pablintino · 2024-11-28T16:51:03Z

ci/playbooks/kuttl/deploy-deps.yaml

+        - has_compute | bool
+      ansible.builtin.assert:
+        that:
+          - "'compute' in crc_ci_bootstrap_networks_out"


Why enforcing the instance name? I mean, you already used a different criteria to check if a compute is available, based on a regex. I'd vote to stick to a fixed name or pick the first one that is called ^compute.*.

same as above, removing this tasks as we won't have computes for kuttl

This change attempts to make the approach that nova-operator uses to run kuttl more generic, so it can be used in other operators that follow a similar patter in their tests, like watcher-operator.

SeanMooney

i have one comemnt inline but i bleive this is more or less good as is.

we can hook this via a zuul pre-run playbook in a child job but wanted to see if people tough having an actually ci framework hook was warranted or not.

SeanMooney · 2024-11-29T12:44:25Z

ci/playbooks/kuttl/deploy-deps.yaml

+              oc wait InstallPlan {{ cifmw_edpm_prepare_wait_installplan_out.stdout }}
+              --namespace=openstack-operators
+              --for=jsonpath='{.status.phase}'=Complete --timeout=20m
+


we may want to have a hook here to install operators that are not part of the meta operator or other customisation.

i.e. we need to be able to install watcher operator here after the OpenStack operator is installed.

the "make kuttl-test-prep" should not actually depend on the operator its testing being installed so this will still work as we can add a pre-run playbook to the job that inherits form this so its not a blocker.

we have a hookpoint as a result of that but just wanted to highlight this.

just to illustrate how we do it in watcher-operator here is the hook to install it https://github.com/openstack-k8s-operators/watcher-operator/pull/14/files#diff-108978819c05ae183d88ec87959c2341a94cfc3f9465e3aeee82d554217b4f58R56

openshift-ci bot added the do-not-merge/work-in-progress label Nov 26, 2024

cescgina mentioned this pull request Nov 26, 2024

Add kuttl job openstack-k8s-operators/watcher-operator#14

Draft

SeanMooney reviewed Nov 26, 2024

View reviewed changes

zuul.d/kuttl_multinode.yaml Show resolved Hide resolved

cescgina force-pushed the kuttl_without_install_yamls branch 6 times, most recently from 9758ec8 to df95669 Compare November 27, 2024 18:21

cescgina force-pushed the kuttl_without_install_yamls branch 3 times, most recently from 403e323 to 61a85b4 Compare November 28, 2024 09:01

cescgina mentioned this pull request Nov 28, 2024

Use cifmw kuttl job as parent job for reusability openstack-k8s-operators/nova-operator#902

Open

cescgina force-pushed the kuttl_without_install_yamls branch from 61a85b4 to b66bb52 Compare November 28, 2024 10:37

cescgina marked this pull request as ready for review November 28, 2024 12:54

openshift-ci bot removed the do-not-merge/work-in-progress label Nov 28, 2024

github-actions bot added the Ready For Review label Nov 28, 2024

cescgina requested a review from SeanMooney November 28, 2024 16:05

cescgina added a commit to cescgina/watcher-operator that referenced this pull request Nov 28, 2024

Add kuttl job for watcher-operator

5340526

This job uses a parent job defined in [1] based on the existing nova-operator. [1] openstack-k8s-operators/ci-framework#2571

pablintino reviewed Nov 28, 2024

View reviewed changes

Add job to run kuttl without install_yamls

903bc91

This change attempts to make the approach that nova-operator uses to run kuttl more generic, so it can be used in other operators that follow a similar patter in their tests, like watcher-operator.

cescgina force-pushed the kuttl_without_install_yamls branch from b66bb52 to 903bc91 Compare November 28, 2024 17:01

github-actions bot added Ready For Review and removed Ready For Review labels Nov 28, 2024

cescgina requested a review from pablintino November 29, 2024 10:30

SeanMooney approved these changes Nov 29, 2024

View reviewed changes

SeanMooney added the lgtm label Nov 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add job to run kuttl without install_yamls #2571

Add job to run kuttl without install_yamls #2571

cescgina commented Nov 26, 2024 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Nov 26, 2024

openshift-ci bot commented Nov 26, 2024

softwarefactory-project-zuul bot commented Nov 27, 2024

cescgina commented Nov 28, 2024

cescgina commented Nov 28, 2024

pablintino Nov 28, 2024

cescgina Nov 28, 2024

pablintino Nov 28, 2024

cescgina Nov 28, 2024

pablintino Nov 28, 2024

cescgina Nov 28, 2024

pablintino Nov 28, 2024

cescgina Nov 28, 2024

pablintino Nov 28, 2024

cescgina Nov 28, 2024

SeanMooney left a comment

SeanMooney Nov 29, 2024

cescgina Nov 29, 2024

		KUBECONFIG: "{{ cifmw_openshift_kubeconfig }}"
		PATH: "{{ cifmw_path \| default(ansible_env.PATH) }}"

Add job to run kuttl without install_yamls #2571

Are you sure you want to change the base?

Add job to run kuttl without install_yamls #2571

Conversation

cescgina commented Nov 26, 2024 • edited by openshift-ci bot Loading

openshift-ci bot commented Nov 26, 2024

openshift-ci bot commented Nov 26, 2024

softwarefactory-project-zuul bot commented Nov 27, 2024

cescgina commented Nov 28, 2024

cescgina commented Nov 28, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SeanMooney left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cescgina commented Nov 26, 2024 •

edited by openshift-ci bot

Loading